774362 - Switch to new drag and drop api for go and search buttons

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Ian Neal]

Attachment: Switch go and search buttons

This patch makes use of the helper introduced in bug 774125 and changes the go and search buttons to use the new API.

Comment 1

[[e-mail]]

Comment on attachment 642640 [details] [diff] [review]
Switch go and search buttons

>+                ondragover="goButtonObserver.onDragOver(event);"
>+                ondragenter="goButtonObserver.onDragOver(event);"
Do we need both? We didn't seem to need them before...

>+  onDragOver: function (aEvent)
[Could almost write this as onDragOver: dragLinkOver, ]

>+  onDragExit: function (aEvent)
>+  {
>+  },
Is it worth keeping this?

>+  onDrop: function (aEvent)
>+  {
>+    var url = Services.droppedLinkHandler.dropLink(aEvent, {});
Does this work if you drag a string matching a bookmark keyword, rather than a link?

Comment 2

[Ian Neal]

(In reply to [e-mail] from comment #1)
> Comment on attachment 642640 [details] [diff] [review]
> Switch go and search buttons
> 
> >+                ondragover="goButtonObserver.onDragOver(event);"
> >+                ondragenter="goButtonObserver.onDragOver(event);"
> Do we need both? We didn't seem to need them before...
Indeed it appears we don't.
> 
> >+  onDragOver: function (aEvent)
> [Could almost write this as onDragOver: dragLinkOver, ]
Fixed.
> 
> >+  onDragExit: function (aEvent)
> >+  {
> >+  },
> Is it worth keeping this?
Removed.
> 
> >+  onDrop: function (aEvent)
> >+  {
> >+    var url = Services.droppedLinkHandler.dropLink(aEvent, {});
> Does this work if you drag a string matching a bookmark keyword, rather than
> a link?
Yes, it does.

Comment 3

[Ian Neal]

Attachment: Less drag exit

Revised as per suggestions.

Comment 4

[Ian Neal]

Attachment: Fix bitrot [Checked in: Comment 6]

Changes since last version:
* Fixed bitrot from update to dependent bug.

Comment 5

[[e-mail]]

Comment on attachment 647365 [details] [diff] [review]
Fix bitrot [Checked in: Comment 6]

>+                ondragexit="goButtonObserver.onDragExit(event);"/>
>+                ondragexit="searchButtonObserver.onDragExit(event);"/>
Nit: Still too much drag exit. r=me with that fixed.

Comment 6

[Ian Neal]

Comment on attachment 647365 [details] [diff] [review]
Fix bitrot [Checked in: Comment 6]

With ondragexits removed:
http://hg.mozilla.org/comm-central/rev/54f3c239ef7a