Fix PA detection hack in sydneyaudio ALSA

RESOLVED FIXED in mozilla17

Status

()

Product:
Core
Component:
Audio/Video
Status:
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Version:
Trunk
Target:
mozilla17
Platform:
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

patch v0
1.18 KB, patch
cajbir
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
The current code almost always evaluates to true due to misuse of strncmp().
(Assignee)

Comment 1

•
6 years ago 
Created attachment 642722 [details] [diff] [review]
patch v0
Attachment #642722 - Flags: review?(chris.double)
 (Assignee)

Updated

•
6 years ago
Attachment #642722 - Attachment is obsolete: true
Attachment #642722 - Flags: review?(chris.double)
 (Assignee)

Comment 2

•
6 years ago 
Created attachment 642724 [details] [diff] [review]
patch v0

Previously attached version had a typo.
Attachment #642724 - Flags: review?(chris.double)

Updated

•
6 years ago
Attachment #642724 - Flags: review?(chris.double) → review+

Comment 4

•
6 years ago 
https://hg.mozilla.org/mozilla-central/rev/752d38520b85
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.