Open Bug 774475 Opened 10 years ago Updated 10 years ago

http://maps.stamen.com/ renders all tiles in upper-left corner

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

People

(Reporter: dholbert, Unassigned)

References

()

Details

I noticed today that this site...
  http://maps.stamen.com/toner/embed
... is broken in current nightly. (along with its more-complex version http://maps.stamen.com/ )

It renders the upper-left map tile, and basically nothing else.  From using "inspect element", it looks like it's rendering all of the tiles in the same location.

This works correctly (no bug) in nightlies from last week.  I got this regression range:
Last good nightly: 2012-07-11
First bad nightly: 2012-07-12
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=53860f11100c&tochange=46804c31366b
Summary: http://maps.stamen.com/ → http://maps.stamen.com/ renders all tiles in upper-left corner
Over a slow network, it's more visible that the images are loading on top of each other, all in the top left corner.

I'm going to try to get a better range from https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64/
Actually, after looking at the error messages and modestmaps source code it's almost certainly:
https://hg.mozilla.org/mozilla-central/rev/2e3c67b2d95d

If they sniffed for the presence of "transition" in addition to sniffing for the prefixed forms, and preferred it to MozTransition, they'd be fine since they'd then only add "px" when transition wasn't there and MozTransition was.
The problematic code was fixed already in https://github.com/stamen/modestmaps-js/commit/96da436a32203c514e4efc5539d87ec67fa0e9f9 , but what maps.stamen.com is using hasn't been updated.
But I did submit https://github.com/stamen/modestmaps-js/pull/141 while I was looking at the code.
Blocks: 719054
... which I was asked to turn into https://github.com/modestmaps/modestmaps-js/pull/37
Oh, and to be clear, applying that fix to the earlier release that they're currently using on the site would also fix this.
You need to log in before you can comment on or make changes to this bug.