Closed
Bug 774491
Opened 13 years ago
Closed 13 years ago
Use cached x/y values and some arithmetic instead of also caching left/top values
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
|
9.83 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
The patch in bug 773819 was actually kinda dumb. We don't need to cache left/top for the handles, since we're already caching the x/y of the corners of the selection, and you can determine one from the other. This gets rid of those getBoundingClientRect() calls altogether.
Some other things in here:
-I found that I didn't need HANDLE_HORIZONTAL_OFFSET anymore... not really sure why that hack was there in the first place (probably just covering up some other issue).
-I forgot to add a call to updateViewOffsetScroll() after the zoom changes, and this was causing handle mis-positioning when zooming.
Attachment #642760 -
Flags: review?(mark.finkle)
|
||
Updated•13 years ago
|
Attachment #642760 -
Flags: review?(mark.finkle) → review+
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → margaret.leibovic
|
|
Assignee | |
Comment 1•13 years ago
|
||
Target Milestone: --- → Firefox 17
|
||
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•