Use cached x/y values and some arithmetic instead of also caching left/top values

RESOLVED FIXED in Firefox 17

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 17
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 642760 [details] [diff] [review]
patch

The patch in bug 773819 was actually kinda dumb. We don't need to cache left/top for the handles, since we're already caching the x/y of the corners of the selection, and you can determine one from the other. This gets rid of those getBoundingClientRect() calls altogether. 

Some other things in here:
-I found that I didn't need HANDLE_HORIZONTAL_OFFSET anymore... not really sure why that hack was there in the first place (probably just covering up some other issue).
-I forgot to add a call to updateViewOffsetScroll() after the zoom changes, and this was causing handle mis-positioning when zooming.
Attachment #642760 - Flags: review?(mark.finkle)
Attachment #642760 - Flags: review?(mark.finkle) → review+
(Assignee)

Updated

7 years ago
Assignee: nobody → margaret.leibovic
(Assignee)

Comment 1

7 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/edd3c6776ae9
Target Milestone: --- → Firefox 17
https://hg.mozilla.org/mozilla-central/rev/edd3c6776ae9
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.