77451 - Search UI: crash filing a message to orig/residence folder.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using apr23 commercial trunk build

If you use File from the search results pane and choose the origination folder
as the move destination a crash occurs.

I think there is an older and general bug to prohibit/disable selecting same
folder for move/file destatination in all mail windows (I will look for that
bug), but when doing this in the main mail window at least we don't crash.

Steps:
1.  Open a mail folder (local or IMAP).  Search|Search Mail/News Messages and
initiate a simple search which will yield matches.
2.  Select a search result, use the search UI File button and select the same
folder as the message resides in as the destination for the move/file.

Result:  crash occurs.

Expected:  Should disable or otherwise prohibit moving message to same folder,
but at least we shouldn't crash.

Comment 1

[laurel]

Attachment: talkback 29573013

Comment 2

[laurel]

Info: The original bug (I think it is still considered the master bug) for
disabling source folder in move menu is bug 16717.

Comment 3

[scottputterman]

this is pretty easy to reproduce.  reassigning to naving

Comment 4

[Navin Gupta]

Attachment: proposed fix.

Comment 5

[Navin Gupta]

Preventing copy/move to go ahead in such cases, until bug 16717 gets fixed.

cc bienvenu for review. 

Comment 6

[Navin Gupta]

Attachment: proposed fix.

Comment 7

[Navin Gupta]

Prevent the CopyMessages to go ahead for both the db view and search view. 

Comment 8

[Navin Gupta]

cc gayatrib for review. 

Comment 9

[David :Bienvenu]

sr=bienvenu

Comment 10

[gayatrib]

r=gayatrib

Comment 11

[(not reading, please use [e-mail] instead)]

r=sspitzer

please assert in this case, since ideally we shouldn't have source == dest.

Once we fix, #16717 it will be impossible to assert.

thanks navin.

Comment 12

[Navin Gupta]

fix checked in. 

Comment 13

[laurel]

OK using may08 commercial trunk build: mac OS 9.0, win98 (classic skin)
OK using may03 commercial trunk build: linux rh6.2 (classic skin)
Verified using classic skin due to open bug 78686