The default bug view has changed. See this FAQ.

Remove uncessary typeOf hooks

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 642776 [details] [diff] [review]
v1

The default behaviour for objects without a typeOf hook is to return "object". In the most cases we actually want that and don't need to implement that hook and explicitly return JSTYPE_OBJECT. This is mostly done to prevent bailouts for MTypeOfIs on dense arrays in IonMonkey, which are probably common.
Attachment #642776 - Flags: review?(dvander)
(Assignee)

Updated

5 years ago
Blocks: 725966
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 1

5 years ago
Created attachment 642778 [details] [diff] [review]
v1

Forgot to refresh.
Attachment #642776 - Attachment is obsolete: true
Attachment #642776 - Flags: review?(dvander)
(Assignee)

Updated

5 years ago
Attachment #642778 - Flags: review?(dvander)
Attachment #642778 - Flags: review?(dvander) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/8dd41661cf09
(Assignee)

Comment 3

5 years ago
We could also land this on m-i.
Whiteboard: [js:t]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.