Closed
Bug 774510
Opened 12 years ago
Closed 12 years ago
Remove uncessary typeOf hooks
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: evilpie, Assigned: evilpie)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file, 1 obsolete file)
|
5.87 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
The default behaviour for objects without a typeOf hook is to return "object". In the most cases we actually want that and don't need to implement that hook and explicitly return JSTYPE_OBJECT. This is mostly done to prevent bailouts for MTypeOfIs on dense arrays in IonMonkey, which are probably common.
Attachment #642776 -
Flags: review?(dvander)
|
Assignee | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 1•12 years ago
|
||
Forgot to refresh.
Attachment #642776 -
Attachment is obsolete: true
Attachment #642776 -
Flags: review?(dvander)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #642778 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #642778 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/8dd41661cf09
|
|
Assignee | |
Comment 3•12 years ago
|
||
We could also land this on m-i.
|
||
Updated•12 years ago
|
Whiteboard: [js:t]
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•