Last Comment Bug 774510 - Remove uncessary typeOf hooks
: Remove uncessary typeOf hooks
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: AWAY Tom Schuster [:evilpie]
:
:
Mentors:
Depends on:
Blocks: 725966
  Show dependency treegraph
 
Reported: 2012-07-16 16:07 PDT by AWAY Tom Schuster [:evilpie]
Modified: 2012-07-20 16:37 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (5.87 KB, patch)
2012-07-16 16:07 PDT, AWAY Tom Schuster [:evilpie]
no flags Details | Diff | Splinter Review
v1 (5.87 KB, patch)
2012-07-16 16:09 PDT, AWAY Tom Schuster [:evilpie]
dvander: review+
Details | Diff | Splinter Review

Description AWAY Tom Schuster [:evilpie] 2012-07-16 16:07:19 PDT
Created attachment 642776 [details] [diff] [review]
v1

The default behaviour for objects without a typeOf hook is to return "object". In the most cases we actually want that and don't need to implement that hook and explicitly return JSTYPE_OBJECT. This is mostly done to prevent bailouts for MTypeOfIs on dense arrays in IonMonkey, which are probably common.
Comment 1 AWAY Tom Schuster [:evilpie] 2012-07-16 16:09:57 PDT
Created attachment 642778 [details] [diff] [review]
v1

Forgot to refresh.
Comment 2 AWAY Tom Schuster [:evilpie] 2012-07-18 04:53:07 PDT
http://hg.mozilla.org/projects/ionmonkey/rev/8dd41661cf09
Comment 3 AWAY Tom Schuster [:evilpie] 2012-07-18 04:53:27 PDT
We could also land this on m-i.

Note You need to log in before you can comment on or make changes to this bug.