Closed Bug 774510 Opened 10 years ago Closed 10 years ago

Remove uncessary typeOf hooks

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

(Whiteboard: [js:t])

Attachments

(1 file, 1 obsolete file)

v1
5.87 KB, patch
dvander
: review+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
The default behaviour for objects without a typeOf hook is to return "object". In the most cases we actually want that and don't need to implement that hook and explicitly return JSTYPE_OBJECT. This is mostly done to prevent bailouts for MTypeOfIs on dense arrays in IonMonkey, which are probably common.
Attachment #642776 - Flags: review?(dvander)
Blocks: 725966
OS: Linux → All
Hardware: x86_64 → All
Attached patch v1 — — Splinter Review 
Forgot to refresh.
Attachment #642776 - Attachment is obsolete: true
Attachment #642776 - Flags: review?(dvander)
Attachment #642778 - Flags: review?(dvander)
Attachment #642778 - Flags: review?(dvander) → review+
We could also land this on m-i.
Whiteboard: [js:t]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.