Closed
Bug 774553
Opened 12 years ago
Closed 12 years ago
Marionette disabled on B2G due to pref change
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: jgriffin, Assigned: jgriffin)
References
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
mdas
:
review+
|
Details | Diff | Splinter Review |
In bug 772310, I changed Marionette to use prefHasUserValue before attempting to read the pref, in order to avoid a spurious assert on Firefox.
On B2G, this disables Marionette. It turns out that prefHasUserValue is only true if that pref has a non-default value. For B2G, the default value is true, and thus prefHasUserValue returns false.
|
Assignee | |
Comment 1•12 years ago
|
||
This patch uses a try/catch block when reading the marionette.defaultPrefs.enabled pref, so it will work whether or not it has a default value.
It also reorganizes the logging code in the same file a bit to make troubleshooting marionette-isn't-loading problems a bit easier.
Attachment #642836 -
Flags: review?(mdas)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 642836 [details] [diff] [review]
patch v0.3
Review of attachment 642836 [details] [diff] [review]:
-----------------------------------------------------------------
good catch, thanks!
Attachment #642836 -
Flags: review?(mdas) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Assignee: nobody → jgriffin
Target Milestone: --- → mozilla17
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•