774556 - Remove nsIDOMWindowPerformance* XPCOM interfaces

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

This is a follow-up to bug 749101.  We don't have any native code which depends on these interfaces, so we should just kill them.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

This patch removes these interfaces, but with it, window.performance returns undefined.  I guess that happens because nsIDOMWindow::GetPerformance now returns an nsISupports*.  Boris, do you know what I need to do in order to fix that?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 642840 [details] [diff] [review]
Patch (v1)

This looks fine in general.  The undefined bit is due to this change:

-  DOM_CLASSINFO_MAP_CONDITIONAL_ENTRY(nsIDOMWindowPerformance,                 \
-                                      nsGlobalWindow::HasPerformanceSupport()) \

which makes Window not implement that interface as far as script is concerned.  You should revert it that part.

Comment 3

[(no longer active)]

(In reply to comment #2)
> Comment on attachment 642840 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=642840
> Patch (v1)
> 
> This looks fine in general.  The undefined bit is due to this change:
> 
> -  DOM_CLASSINFO_MAP_CONDITIONAL_ENTRY(nsIDOMWindowPerformance,                
> \
> -                                      nsGlobalWindow::HasPerformanceSupport())
> \
> 
> which makes Window not implement that interface as far as script is concerned. 
> You should revert it that part.

I tried to put that part back in using nsISupports, but window.performance is still undefined...

Comment 4

[(no longer active)]

(In reply to comment #2)
> Comment on attachment 642840 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=642840
> Patch (v1)
> 
> This looks fine in general.  The undefined bit is due to this change:
> 
> -  DOM_CLASSINFO_MAP_CONDITIONAL_ENTRY(nsIDOMWindowPerformance,                
> \
> -                                      nsGlobalWindow::HasPerformanceSupport())
> \
> 
> which makes Window not implement that interface as far as script is concerned. 
> You should revert it that part.

I tried to put that part back in using nsISupports, but window.performance is still undefined...

Comment 5

[Boris Zbarsky [:bzbarsky]]

Just put it back exactly the way it was.  nsIDOMWindowPerformance is not one of the interfaces you're removing...

Comment 6

[(no longer active)]

Attachment: Patch (v1)

Oops, you're right!

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 642859 [details] [diff] [review]
Patch (v1)

It might not be a bad idea to put the constants in the mozilla::dom::PerformanceNavigation namespace or the nsPerformanceNavigation class or something.

r=me

Comment 8

[(no longer active)]

Done!

https://hg.mozilla.org/integration/mozilla-inbound/rev/b722257d15b3

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b722257d15b3