The default bug view has changed. See this FAQ.

Typo in pymake.functions.SubstitutionRef.__repr__

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pymake])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 642842 [details] [diff] [review]
Fix typo

There is a typo in pymake.functions.SubstitutionRef.__repr__ that causes this function to always raise. This prevents the tests/parsertests.py tests from passing.

It makes me wonder if the pymake tests should be hooked up to the build system. Maybe the make/pymake comparison ones would be a little expensive. But, the unit tests execute in just a few milliseconds.
Attachment #642842 - Flags: review?(khuey)
I would support running them as part of the regular build.
Comment on attachment 642842 [details] [diff] [review]
Fix typo

Review of attachment 642842 [details] [diff] [review]:
-----------------------------------------------------------------

doh!
Attachment #642842 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/985e2a9dc8fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/a10834675f4d
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/a10834675f4d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.