Last Comment Bug 774558 - Typo in pymake.functions.SubstitutionRef.__repr__
: Typo in pymake.functions.SubstitutionRef.__repr__
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla17
Assigned To: Gregory Szorc [:gps] (away until 2017-03-20)
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on:
  Show dependency treegraph
Reported: 2012-07-16 19:56 PDT by Gregory Szorc [:gps] (away until 2017-03-20)
Modified: 2012-07-20 21:04 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix typo (874 bytes, patch)
2012-07-16 19:56 PDT, Gregory Szorc [:gps] (away until 2017-03-20)
khuey: review+
Details | Diff | Splinter Review

Description User image Gregory Szorc [:gps] (away until 2017-03-20) 2012-07-16 19:56:52 PDT
Created attachment 642842 [details] [diff] [review]
Fix typo

There is a typo in pymake.functions.SubstitutionRef.__repr__ that causes this function to always raise. This prevents the tests/ tests from passing.

It makes me wonder if the pymake tests should be hooked up to the build system. Maybe the make/pymake comparison ones would be a little expensive. But, the unit tests execute in just a few milliseconds.
Comment 1 User image Ted Mielczarek [:ted.mielczarek] 2012-07-17 05:42:25 PDT
I would support running them as part of the regular build.
Comment 2 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-07-20 07:01:22 PDT
Comment on attachment 642842 [details] [diff] [review]
Fix typo

Review of attachment 642842 [details] [diff] [review]:

Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-07-20 21:04:27 PDT

Note You need to log in before you can comment on or make changes to this bug.