Typo in pymake.functions.SubstitutionRef.__repr__

RESOLVED FIXED in mozilla17

Status

RESOLVED FIXED
7 years ago
11 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla17

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pymake])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 642842 [details] [diff] [review]
Fix typo

There is a typo in pymake.functions.SubstitutionRef.__repr__ that causes this function to always raise. This prevents the tests/parsertests.py tests from passing.

It makes me wonder if the pymake tests should be hooked up to the build system. Maybe the make/pymake comparison ones would be a little expensive. But, the unit tests execute in just a few milliseconds.
Attachment #642842 - Flags: review?(khuey)
I would support running them as part of the regular build.
Comment on attachment 642842 [details] [diff] [review]
Fix typo

Review of attachment 642842 [details] [diff] [review]:
-----------------------------------------------------------------

doh!
Attachment #642842 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/a10834675f4d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

11 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.