774627 - Remove d2d pragma lib directives from MetroWidget

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

// XXX move
#pragma comment(lib, "dwrite.lib")
#pragma comment(lib, "d2d1.lib")
#pragma comment(lib, "d3d11.lib")

I think gfx code should be taking care of proper linking of libs. If it's not, it should be.

Comment 1

[Makoto Kato [:m_kato]]

This #pragma are unnecessary.  If necessary, Windows XP cannot load this xul.dll.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 716965 [details] [diff] [review]
fix

Thanks!

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8bac7570f071

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8bac7570f071