Closed Bug 774627 Opened 12 years ago Closed 11 years ago

Remove d2d pragma lib directives from MetroWidget

Categories

(Core :: Widget: Win32, defect)

Product:
Core
Component:
Widget: Win32
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: jimm, Assigned: m_kato)

References

Details

Attachments

(1 file)

fix
1.76 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
// XXX move
#pragma comment(lib, "dwrite.lib")
#pragma comment(lib, "d2d1.lib")
#pragma comment(lib, "d3d11.lib")

I think gfx code should be taking care of proper linking of libs. If it's not, it should be.
Blocks: 797201
This #pragma are unnecessary.  If necessary, Windows XP cannot load this xul.dll.
Attached patch fix — — Splinter Review 

    
  

        Attachment #716965 -
        Flags: review?(jmathies)

    
    

    
  
Comment on attachment 716965 [details] [diff] [review]
fix

Thanks!

        Attachment #716965 -
        Flags: review?(jmathies) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/8bac7570f071
Assignee: nobody → m_kato
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
OS: Windows 8 Metro → Windows 8.1

          You need to log in
          before you can comment on or make changes to this bug.