The default bug view has changed. See this FAQ.

Make media.navigator.enabled visible

VERIFIED FIXED in mozilla17

Status

()

Core
WebRTC
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: anant, Assigned: anant)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa!])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
The pref is not visible via about:config and has to be created manually at the moment.
(Assignee)

Comment 1

5 years ago
Created attachment 642965 [details] [diff] [review]
Add media.navigator.enabled to default prefs

Trim some whitespace and add media.navigator.enabled to default pref list (turned off).
Assignee: nobody → anant
Status: NEW → ASSIGNED
Attachment #642965 - Flags: review?(felipc)
(In reply to Anant Narayanan [:anant] from comment #0)
> The pref is not visible via about:config and has to be created manually at
> the moment.

Can we have a bug for making this visible in the desktop webrt?
(In reply to Jason Smith [:jsmith] from comment #2)
> (In reply to Anant Narayanan [:anant] from comment #0)
> > The pref is not visible via about:config and has to be created manually at
> > the moment.
> 
> Can we have a bug for making this visible in the desktop webrt?

Or we could just implement it here along with the desktop firefox changes.
(Assignee)

Comment 4

5 years ago
Created attachment 643014 [details] [diff] [review]
Add media.navigator.enabled to default prefs

Add pref to WebRT as well.
Attachment #642965 - Attachment is obsolete: true
Attachment #642965 - Flags: review?(felipc)
Attachment #643014 - Flags: review?(felipc)
Is there a reason not to use all.js instead and include it everywhere?

I too dislike trailing spaces but we usually don't fix them in unrelated changes because your changeset will look obscure and it will change the blame making it harder to find the original bug where those lines were added.
anant: can you address Felipe's comments and repost?  Also, if there any other peers who can review this patch, let's add them as possible reviewers since people using nightlies are getting tripped up looking for the pref, and felipe's away, and may not get to this bug this week even when he gets back.
(Assignee)

Comment 7

5 years ago
Created attachment 646177 [details] [diff] [review]
Make media.navigator.enabled visible in about:config

Sounds good! Felipe is probably busy this week, but I'm not sure who else to flag.
Attachment #643014 - Attachment is obsolete: true
Attachment #643014 - Flags: review?(felipc)
Attachment #646177 - Flags: review?(felipc)
Attachment #646177 - Flags: review?(felipc) → review+
(Assignee)

Comment 8

5 years ago
Thanks Gavin!

https://hg.mozilla.org/integration/mozilla-inbound/rev/80a25e052d86
https://hg.mozilla.org/mozilla-central/rev/80a25e052d86
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

Updated

5 years ago
QA Contact: jsmith
Whiteboard: [qa+]
On a fresh firefox profile, I am seeing media.navigator.enabled set to false in the prefs, so the firefox piece works here. However, the web runtime piece does not work - checking prefs.js shows no evidence of the media.navigator.enabled pref at all.

Any ideas?
Whiteboard: [qa+] → [qa verification failed]
(In reply to Jason Smith [:jsmith] from comment #10)
> On a fresh firefox profile, I am seeing media.navigator.enabled set to false
> in the prefs, so the firefox piece works here. However, the web runtime
> piece does not work - checking prefs.js shows no evidence of the
> media.navigator.enabled pref at all.
> 
> Any ideas?

prefs.js in the webapprt/defaults/preferences folder are overrides/additions to the prefs defined by all.js. The runtime first loads all.js and then prefs.js. So the pref is not supposed to show up in that file, but if you load about:config inside the webapprt you'll see that media.navigator.enabled is present. (I just did this and verified that the pref is there)
Alright, I'll mark as verified then given that you were able to see in about:config for the runtime.
Status: RESOLVED → VERIFIED
Whiteboard: [qa verification failed] → [qa!]
You need to log in before you can comment on or make changes to this bug.