Closed
Bug 774688
Opened 12 years ago
Closed 12 years ago
WebGL compositing broken with basic layers
Categories
(Core :: Graphics: Layers, defect, P1)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: bjacob, Assigned: jgilbert)
References
Details
(Keywords: regression)
Attachments
(2 files)
1.37 KB,
patch
|
bas.schouten
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
1.37 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
STR: * set layers.acceleration.disabled=true * visit any page with a WebGL animation actual results: animation is frozen, you can get a new frame by switching tabs. Last good nightly: march 26, http://hg.mozilla.org/mozilla-central/rev/ba4983d9c1f9 first bad nightly: march 27, http://hg.mozilla.org/mozilla-central/rev/c3cb87871829
Assignee | ||
Comment 1•12 years ago
|
||
This is very likely to be a regression from bug 735378.
Severity: normal → critical
Depends on: 735378
Keywords: regression
OS: Windows 7 → All
Priority: -- → P1
Hardware: x86_64 → All
Reporter | ||
Comment 2•12 years ago
|
||
This bug is a strong argument in favor of running tests with BasicLayers. Don't need any specific hardware for that, just run with this preference: layers.acceleration.disabled=true. It's still what the majority of our Windows users use, and the performance can still be acceptable for simple games.
Assignee | ||
Comment 3•12 years ago
|
||
Adds the needed Flush and MarkDirty.
Attachment #643107 -
Flags: review?(bas.schouten)
Assignee | ||
Updated•12 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•12 years ago
|
Assignee: jgilbert → nobody
Component: Canvas: WebGL → Graphics: Layers
Updated•12 years ago
|
Attachment #643107 -
Flags: review?(bas.schouten) → review+
Updated•12 years ago
|
Assignee: nobody → jgilbert
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cedfa313d168
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla17
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cedfa313d168
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
status-firefox-esr10:
--- → ?
status-firefox14:
--- → affected
status-firefox15:
--- → affected
status-firefox16:
--- → affected
status-firefox17:
--- → fixed
tracking-firefox-esr10:
--- → ?
tracking-firefox14:
--- → ?
tracking-firefox15:
--- → ?
tracking-firefox16:
--- → ?
tracking-firefox17:
--- → ?
Assignee | ||
Comment 6•12 years ago
|
||
Comment on attachment 643107 [details] [diff] [review] Mark our reused buffer as dirty [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 735378 User impact if declined: WebGL will display uselessly on BasicLayers. This is an uncommon combination, but it does occur. This is worse than simply failing to start WebGL. Testing completed (on m-c, etc.): On m-c and easy to test. Risk to taking this patch (and alternatives if risky): Very low. The problem is now well understood and the fix is simple. String or UUID changes made by this patch: None. Testing this is easy: Set the pref 'layers.acceleration.disabled' to true, and create a new window. WebGL should fail to display properly, even if it works fine without the change to the pref.
Attachment #643107 -
Attachment is patch: true
Attachment #643107 -
Flags: approval-mozilla-beta?
Attachment #643107 -
Flags: approval-mozilla-aurora?
Comment 7•12 years ago
|
||
If bug 735378 is the regressing issue, then the ESR is unaffected.
Comment 8•12 years ago
|
||
Comment on attachment 643107 [details] [diff] [review] Mark our reused buffer as dirty [Triage Comment] Approving for both Aurora 16 and Beta 15, since this is a 14 regression and has a low-risk fix.
Attachment #643107 -
Flags: approval-mozilla-beta?
Attachment #643107 -
Flags: approval-mozilla-beta+
Attachment #643107 -
Flags: approval-mozilla-aurora?
Attachment #643107 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/8dda64a9d0cc
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/f670d47f696c
Comment 12•12 years ago
|
||
Verified on Firefox 15 beta 3 that WebGL demos are not broken nor freeze when setting the user pref layers.acceleration.disabled to true. Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6: Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0 Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0
Comment 13•12 years ago
|
||
Verified on Firefox 16 beta 4 that WebGL demos are not broken nor freeze when user pref layers.acceleration.disabled=true. Verified on several WebGL demos as: http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightMe.html http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightLOD.html http://webglsamples.googlecode.com/hg/aquarium/aquarium.html Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20100101 Firefox/16.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20100101 Firefox/16.0 Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0
QA Contact: simona.marcu
Comment 14•12 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0 Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0 Verified on Firefox 17 beta 1 that WebGL demos are not broken nor freeze (having the preference layers.acceleration.disabled set to true). Verified on several WebGL demos as(on Win 7, Ubuntu 12.04 and Mac OS X 10.7): http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightMe.html http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightLOD.html http://webglsamples.googlecode.com/hg/aquarium/aquarium.html http://webglsamples.googlecode.com/hg/blob/blob.html http://lights.elliegoulding.com/ On Ubuntu 12.04 with ATI Radeon 3000 GraphicsDriver Version3.3.11627 - Firefox crashes when loading any WebGL demo - filed Bug 801699 for this matter. The crash is not reproducible on a computer running Ubuntu with NVidia.
You need to log in
before you can comment on or make changes to this bug.
Description
•