774688 - WebGL compositing broken with basic layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P1)

Description

[Benoit Jacob [:bjacob] (mostly away)]

STR:
* set layers.acceleration.disabled=true
* visit any page with a WebGL animation

actual results:
animation is frozen, you can get a new frame by switching tabs.

Last good nightly: march 26, http://hg.mozilla.org/mozilla-central/rev/ba4983d9c1f9
first bad nightly: march 27, http://hg.mozilla.org/mozilla-central/rev/c3cb87871829

Comment 1

[Kelsey Gilbert [:jgilbert]]

This is very likely to be a regression from bug 735378.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

This bug is a strong argument in favor of running tests with BasicLayers. Don't need any specific hardware for that, just run with this preference: layers.acceleration.disabled=true. It's still what the majority of our Windows users use, and the performance can still be acceptable for simple games.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Mark our reused buffer as dirty

Adds the needed Flush and MarkDirty.

Comment 4

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cedfa313d168

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cedfa313d168

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 643107 [details] [diff] [review]
Mark our reused buffer as dirty

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 735378
User impact if declined: WebGL will display uselessly on BasicLayers. This is an uncommon combination, but it does occur. This is worse than simply failing to start WebGL.
Testing completed (on m-c, etc.): On m-c and easy to test.
Risk to taking this patch (and alternatives if risky): Very low. The problem is now well understood and the fix is simple.
String or UUID changes made by this patch: None.

Testing this is easy:
Set the pref 'layers.acceleration.disabled' to true, and create a new window. WebGL should fail to display properly, even if it works fine without the change to the pref.

Comment 7

[Alex Keybl [:akeybl]]

If bug 735378 is the regressing issue, then the ESR is unaffected.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 643107 [details] [diff] [review]
Mark our reused buffer as dirty

[Triage Comment]
Approving for both Aurora 16 and Beta 15, since this is a 14 regression and has a low-risk fix.

Comment 9

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8dda64a9d0cc

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: backport to beta 15

Beta backport.

Comment 11

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f670d47f696c

Comment 12

[Simona Badau, Desktop Test Engineering]

Verified on Firefox 15 beta 3 that WebGL demos are not broken nor freeze when setting the user pref layers.acceleration.disabled to true.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.6:
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0

Comment 13

[Simona Badau, Desktop Test Engineering]

Verified on Firefox 16 beta 4 that WebGL demos are not broken nor freeze when user pref layers.acceleration.disabled=true.

Verified on several WebGL demos as:
http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightMe.html
http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightLOD.html
http://webglsamples.googlecode.com/hg/aquarium/aquarium.html

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:
Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/20100101 Firefox/16.0
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20100101 Firefox/16.0

Comment 14

[Simona Badau, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Firefox/17.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0

Verified on Firefox 17 beta 1 that WebGL demos are not broken nor freeze (having the preference layers.acceleration.disabled set to true).

Verified on several WebGL demos as(on Win 7, Ubuntu 12.04 and Mac OS X 10.7):
http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightMe.html
http://sandbox.ayzenberg.com/creative_prototypes/html5_/webgl/prototypeEightLOD.html
http://webglsamples.googlecode.com/hg/aquarium/aquarium.html
http://webglsamples.googlecode.com/hg/blob/blob.html
http://lights.elliegoulding.com/

On Ubuntu 12.04 with ATI Radeon 3000 GraphicsDriver Version3.3.11627 - Firefox crashes when loading any WebGL demo - filed Bug 801699 for this matter. The crash is not reproducible on a computer running Ubuntu with NVidia.

Comment 15

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old