Closed Bug 774691 Opened 10 years ago Closed 10 years ago

toolkit/components/osfile/tests/mochi/Makefile.in includes rules.mk twice

Categories

(Toolkit Graveyard :: Build Config, defect)

Product:
Toolkit Graveyard
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Patch v1
1.85 KB, patch
glandium
: review+
Details | Diff | Splinter Review
Attached patch Patch v1 — — Splinter Review 
Patch also contains some related cleanup.
Attachment #642975 - Flags: review?(mh+mozilla)
Blocks: 774049
Comment on attachment 642975 [details] [diff] [review]
Patch v1

Review of attachment 642975 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/osfile/tests/mochi/Makefile.in
@@ +6,5 @@
>  topsrcdir       = @top_srcdir@
>  srcdir          = @srcdir@
>  VPATH           = @srcdir@
>  relativesrcdir  = toolkit/components/osfile/tests/mochi
> +MODULE          = osfile

Usual idiom is to have that after including autoconf.mk.

r=me with that changed.
Attachment #642975 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/bf09f11b69d8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.