Closed
Bug 774691
Opened 13 years ago
Closed 13 years ago
toolkit/components/osfile/tests/mochi/Makefile.in includes rules.mk twice
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Patch also contains some related cleanup.
Attachment #642975 -
Flags: review?(mh+mozilla)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 642975 [details] [diff] [review]
Patch v1
Review of attachment 642975 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/osfile/tests/mochi/Makefile.in
@@ +6,5 @@
> topsrcdir = @top_srcdir@
> srcdir = @srcdir@
> VPATH = @srcdir@
> relativesrcdir = toolkit/components/osfile/tests/mochi
> +MODULE = osfile
Usual idiom is to have that after including autoconf.mk.
r=me with that changed.
Attachment #642975 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
|
||
Updated•7 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•