Last Comment Bug 774812 - JM: Treat known booleans like integers during bitops
: JM: Treat known booleans like integers during bitops
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: general
:
Mentors:
Depends on:
Blocks: 773366
  Show dependency treegraph
 
Reported: 2012-07-17 12:20 PDT by Brian Hackett (:bhackett)
Modified: 2012-07-19 07:36 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.67 KB, patch)
2012-07-17 12:20 PDT, Brian Hackett (:bhackett)
jdemooij: review+
Details | Diff | Splinter Review

Description Brian Hackett (:bhackett) 2012-07-17 12:20:57 PDT
Created attachment 643085 [details] [diff] [review]
patch

Emscripten does things like '(x == y) & 1' to convert booleans into integers, which we currently stub.  This is biting bug 773366.  EZ fix.  Don't know if IM has a similar problem.
Comment 1 Jan de Mooij [:jandem] 2012-07-18 01:43:49 PDT
Comment on attachment 643085 [details] [diff] [review]
patch

Review of attachment 643085 [details] [diff] [review]:
-----------------------------------------------------------------

Just checked, Ion doesn't have this problem, for (x == y) & 1:

[jaeger] Insns            cmpl       %ecx, %eax
[jaeger] Insns            sete       %dl
[jaeger] Insns            movzbl     %edx, %edx
[jaeger] Insns            andl       $0x1, %edx
Comment 2 Brian Hackett (:bhackett) 2012-07-18 05:44:28 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a11f086069a
Comment 3 Ed Morley [:emorley] 2012-07-19 07:36:49 PDT
https://hg.mozilla.org/mozilla-central/rev/9a11f086069a

Note You need to log in before you can comment on or make changes to this bug.