Closed
Bug 774812
Opened 13 years ago
Closed 13 years ago
JM: Treat known booleans like integers during bitops
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: bhackett1024, Unassigned)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
4.67 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Emscripten does things like '(x == y) & 1' to convert booleans into integers, which we currently stub. This is biting bug 773366. EZ fix. Don't know if IM has a similar problem.
Attachment #643085 -
Flags: review?(jdemooij)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 643085 [details] [diff] [review]
patch
Review of attachment 643085 [details] [diff] [review]:
-----------------------------------------------------------------
Just checked, Ion doesn't have this problem, for (x == y) & 1:
[jaeger] Insns cmpl %ecx, %eax
[jaeger] Insns sete %dl
[jaeger] Insns movzbl %edx, %edx
[jaeger] Insns andl $0x1, %edx
Attachment #643085 -
Flags: review?(jdemooij) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
|
||
Updated•13 years ago
|
Whiteboard: [js:t]
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•