774849 - improve article feedback survey

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P2)

Description

[Kadir Topal [:atopal]]

In the article feedback survey, when the user clicks no:

* He should not be able to click just "other", without being able to leave a comment
* He should not be able to input free form text without selecting one of the options.

* The options should be radio boxes, not check boxes, so only one option can be selected at a time.
* We should add another option called "Firefox problem".

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Making this a 2pter as there is some js tweaking as well as the form tweaking on the backend side.

Comment 3

[Matt Grimes [:Matt_G]]

We've made some edits to the topics list and done some wordsmithing. The requirements listed above don't change, but the topics should be:

* Confusing
* Solution didn't work
* Too long
* Other 
* I have feedback about Firefox

Comment 4

[Kadir Topal [:atopal]]

To clarify, we remove the current options and add the ones in comment 3. 

An additional requirement that we need estimated:

We would like to keep the historical data by mapping it like this, maybe:

* Confusing= confusing+overly technical
* Solution didn't work= Solution didn't work + incorrect info + not complete
* Too long = Too long
* Other= Other

delete "wrong topic".

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #4)
> To clarify, we remove the current options and add the ones in comment 3.

OK 


> An additional requirement that we need estimated:
> 
> We would like to keep the historical data by mapping it like this, maybe:
> 
> * Confusing= confusing+overly technical
> * Solution didn't work= Solution didn't work + incorrect info + not complete
> * Too long = Too long
> * Other= Other
> 
> delete "wrong topic".

The surveys are all stored in JSON so we can't really do that.

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

To summarize what we are doing in this bug.

Make the survey have the following options:
* Confusing
* Solution didn't work
* Too long
* Other 
* I have feedback about Firefox

Radio buttons are used for making a selection. If "Other" or "I have feedback about Firefox" are selected, then the user _must_ enter a comment into a textbox.

If we need to go back and process old data, a new bug should be filed so we can look at it. But like I said, it is all stored as JSON into the database so we are pretty limited as to what we can practically do with it.

Comment 7

[Matt Grimes [:Matt_G]]

That looks good Ricky. Just to be crystal clear, the comment box will be option for other forms of feedback and mandatory for "other" and "I have feedback about Firefox"

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Assigning to :mythmon

Comment 9

[Michael Cooper [:mythmon]]

https://github.com/mozilla/kitsune/pull/740

Comment 10

[Michael Cooper [:mythmon]]

https://github.com/mozilla/kitsune/commit/77d41c6797122357c489cf3f11aa9a4743c61966

Note that, like :r1cky mentioned, this doesn't take care of any data migration, which should be another bug because of the scope.

Comment 11

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was pushed to production a couple of hours ago.