Closed
Bug 774875
Opened 12 years ago
Closed 12 years ago
mozInstall overrides the dest variable and breaks for legacy python case
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozilla/mozbase/blob/a48971b7cd835835efaeef88e3a7c8171b926174/mozinstall/mozinstall/mozinstall.py#L138 We override dest. That isn't good. IMHO, we should just take out the extractall until we can actually use it. For bonus points, we should make a mozfile to handle such things across the board
|
Reporter | |
Comment 1•12 years ago
|
||
Really, we should start a mozfile and move this functionality (and other) into it. But this fixes the basic problem
|
|
Reporter | |
Updated•12 years ago
|
Attachment #643162 -
Flags: review?(wlachance)
|
|
Reporter | |
Comment 2•12 years ago
|
||
filed https://bugzilla.mozilla.org/show_bug.cgi?id=774916 about mozfile
|
|
Reporter | |
Comment 3•12 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=e3c72be4ca7f
|
||
Comment 4•12 years ago
|
||
Comment on attachment 643162 [details] [diff] [review] stupid fix LGTM
Attachment #643162 -
Flags: review?(wlachance) → review+
|
|
Reporter | |
Comment 5•12 years ago
|
||
pushed: https://github.com/mozilla/mozbase/commit/a4da0d6def00e945ee57726a755904d14d7d79bc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•