Closed Bug 774875 Opened 14 years ago Closed 14 years ago

mozInstall overrides the dest variable and breaks for legacy python case

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: k0scist, Unassigned)

References

Details

Attachments

(1 file)

https://github.com/mozilla/mozbase/blob/a48971b7cd835835efaeef88e3a7c8171b926174/mozinstall/mozinstall/mozinstall.py#L138 We override dest. That isn't good. IMHO, we should just take out the extractall until we can actually use it. For bonus points, we should make a mozfile to handle such things across the board
Blocks: 774817
No longer blocks: 774817
Attached patch stupid fix — — Splinter Review
Really, we should start a mozfile and move this functionality (and other) into it. But this fixes the basic problem
Attachment #643162 - Flags: review?(wlachance)
Blocks: 774817
Comment on attachment 643162 [details] [diff] [review] stupid fix LGTM
Attachment #643162 - Flags: review?(wlachance) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: