774911 - Remove pythonpath.py

Status: NEW

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

I'm pretty sure pythonpath.py can go away now that we have a virtualenv.

https://mxr.mozilla.org/mozilla-central/search?string=pythonpath

Basically, everything going through pythonpath.py can be replaced with $(PYTHON). We /may/ need an additional variable in config.mk or autoconf.mk to handle the  PYTHONDONTWRITEBYTECODE case.

If someone confirms my assessment, I'll volunteer to mentor this.

Comment 1

[Gregory Szorc [:gps]]

Better search: https://mxr.mozilla.org/mozilla-central/search?string=pythonpath.py

Comment 2

[Jeff Hammel]

We will have to port all of the "standalone" utils to be "installed" into the virtualenv's path

Comment 3

[Gregory Szorc [:gps]]

(In reply to Jeff Hammel [:jhammel] from comment #2)
> We will have to port all of the "standalone" utils to be "installed" into
> the virtualenv's path

Consolidating all the .py files into packages/modules is probably something that should be done anyway. That's what build/pylib is for!

I wonder if we could add a .pth pointing to build/? Or, is there some magic packaging foo that won't like that there isn't a formal package?

Comment 4

[Jeff Hammel]

adding a .pth is fine.  Really, there are multiple ways of doing this of which that is one

Comment 5

[(not currently active) Ted Mielczarek]

I think bug 841713 is the only non-trivial part of this. Once that's fixed this should be mostly mechanical changes, just changing $(PYTHON_PATH) ... into $(PYTHON) ... and ensuring nothing breaks.

Comment 6

[amith]

@ted: I am newbie, would want start with fixing this bug, and need help in doing it.

Comment 7

[Gregory Szorc [:gps]]

Ted's on vacation, but I can help you.

Using the link in comment #1, first identify all the scripts invoked with pythonpath.py. For each one of these, we'll need to port the code to not use pythonpath.py. If they are passing -I<path> to pythonpath.py, we'll need to ensure those paths are part of the virtualenv created during configure (see /build/virtualenv). If they aren't, we should consider adding those paths to the virtualenv. The easy way to test is to just remove the pythonpath.py from the invocation. If the invocation works, great. If not, we'll need to add paths to the virtualenv environment.

Make sense?

Comment 8

[amith]

sorry for the late reply, I would like to know how to build and run the code that i have made changes to.

Comment 9

[Srikar Ananthula [:srikar]]

Is this completed ? If not please let me know !! I will do this !

Comment 10

[Gregory Szorc [:gps]]

(In reply to Srikar Ananthula [:srikar] from comment #9)
> Is this completed ? If not please let me know !! I will do this !

This is not completed. But it's a somewhat involved bug. It constitutes many small patches to many small Python utilities. Any work, however small, will be appreciated.

Comment 11

[Srikar Ananthula [:srikar]]

I m not working on this !! I am working on other bug. Thanks !

Comment 12

[Rupanshu Verma]

Hey, i am new to open source and I would really like to help. I have been working on python from the past two years and i am really eger to be a part of opem source community.
Any guidance would be really appreciated.

Thanks.

Comment 13

[Jaewoongyu]

I would like to work on this bug if it is possible. Thank you.

Comment 14

[Jaewoongyu]

Attachment: Bug774911

Can I get a feedback?

Comment 15

[Gregory Szorc [:gps]]

Comment on attachment 8936132 [details]
Bug774911

This patch doesn't really do anything meaningful.

But this bug is still actionable. If you have any questions on how to work on it, leave me a needinfo request. You can also ask questions in #build on irc.mozilla.org.