Last Comment Bug 774915 - don't use the property cache for dynamic name lookup
: don't use the property cache for dynamic name lookup
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla17
Assigned To: Luke Wagner [:luke]
: Jason Orendorff [:jorendorff]
Depends on: 784639 795574
  Show dependency treegraph
Reported: 2012-07-17 15:54 PDT by Luke Wagner [:luke]
Modified: 2012-09-29 02:14 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

rm (67.67 KB, patch)
2012-08-20 13:57 PDT, Luke Wagner [:luke]
bhackett1024: review+
Details | Diff | Splinter Review

Description User image Luke Wagner [:luke] 2012-07-17 15:54:25 PDT
With bug 753158, JSOP_NAME will only show up when there is dynamic scoping (eval/with/non-compile-n-go-global).  Name ICs in JM/IM should cover hot uses of JSOP_NAME.  This means there should be very little need for the property cache in JSOP_NAME.  Removing this use should allow us to stop setting delegates, setting extensibleParents, and generating own shapes in case of extensibleParents.
Comment 1 User image Luke Wagner [:luke] 2012-08-20 13:57:29 PDT
Created attachment 653508 [details] [diff] [review]

I had no idea how much grossness this entailed.

 23 files changed, 236 insertions(+), 584 deletions(-)

No change to SS/V8 and green on try.
Comment 2 User image Brian Hackett (:bhackett) 2012-08-21 07:41:44 PDT
Comment on attachment 653508 [details] [diff] [review]

Review of attachment 653508 [details] [diff] [review]:

Comment 4 User image Ryan VanderMeulen [:RyanVM] 2012-08-21 19:09:40 PDT

Note You need to log in before you can comment on or make changes to this bug.