don't use the property cache for dynamic name lookup

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
With bug 753158, JSOP_NAME will only show up when there is dynamic scoping (eval/with/non-compile-n-go-global).  Name ICs in JM/IM should cover hot uses of JSOP_NAME.  This means there should be very little need for the property cache in JSOP_NAME.  Removing this use should allow us to stop setting delegates, setting extensibleParents, and generating own shapes in case of extensibleParents.
Whiteboard: [js:t]
(Assignee)

Comment 1

5 years ago
Created attachment 653508 [details] [diff] [review]
rm

I had no idea how much grossness this entailed.

 23 files changed, 236 insertions(+), 584 deletions(-)

No change to SS/V8 and green on try.
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #653508 - Flags: review?(bhackett1024)
Comment on attachment 653508 [details] [diff] [review]
rm

Review of attachment 653508 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #653508 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/57c1c330e85f
https://hg.mozilla.org/mozilla-central/rev/57c1c330e85f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 784639
Depends on: 795574
You need to log in before you can comment on or make changes to this bug.