Closed
Bug 774915
Opened 13 years ago
Closed 13 years ago
don't use the property cache for dynamic name lookup
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
67.67 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
With bug 753158, JSOP_NAME will only show up when there is dynamic scoping (eval/with/non-compile-n-go-global). Name ICs in JM/IM should cover hot uses of JSOP_NAME. This means there should be very little need for the property cache in JSOP_NAME. Removing this use should allow us to stop setting delegates, setting extensibleParents, and generating own shapes in case of extensibleParents.
|
||
Updated•13 years ago
|
Whiteboard: [js:t]
|
|
Assignee | |
Comment 1•13 years ago
|
||
I had no idea how much grossness this entailed.
23 files changed, 236 insertions(+), 584 deletions(-)
No change to SS/V8 and green on try.
|
||
Comment 2•13 years ago
|
||
Comment on attachment 653508 [details] [diff] [review]
rm
Review of attachment 653508 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #653508 -
Flags: review?(bhackett1024) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•