Closed Bug 774963 Opened 8 years ago Closed 7 years ago

Move the removeDataFromDomain API into its own service

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 18

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file)

The private browsing service API will go away when we switch to per-window PB.  We need to move the removeDataFromDomain API to its own service before that happens.  That API never really belonged there, and perhaps it makes sense for us to move it to places?
Blocks: PBnGen
Blocks: fxPBnGen
Attached patch Patch (v1)Splinter Review
I put that method in its own JS module, ClearRecentHistory.
Assignee: chrislord.net → ehsan
Status: NEW → ASSIGNED
Attachment #667596 - Flags: review?(josh)
Comment on attachment 667596 [details] [diff] [review]
Patch (v1)

Review of attachment 667596 [details] [diff] [review]:
-----------------------------------------------------------------

The contents of removeDataFromDomain are just itching to move to the actual components that own the data, but I'll just file a bug about that some other time.
Attachment #667596 - Flags: review?(josh) → review+
(In reply to comment #3)
> The contents of removeDataFromDomain are just itching to move to the actual
> components that own the data, but I'll just file a bug about that some other
> time.

Well, that stuff should probably get rewritten at some point for performance (by not doing all sorts of terrible sync io on the main thread.  I'm not sure if the refactoring as you suggest it is going to be worth it on its own...
Try run for 84020ccc0708 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=84020ccc0708
Results (out of 13 total builds):
    success: 12
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-84020ccc0708
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d840c9cf30
Target Milestone: --- → Firefox 18
Keywords: addon-compat
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/41d840c9cf30
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.