Move the removeDataFromDomain API into its own service

RESOLVED FIXED in Firefox 18

Status

()

Firefox
Private Browsing
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({addon-compat, dev-doc-needed})

unspecified
Firefox 18
x86
Mac OS X
addon-compat, dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The private browsing service API will go away when we switch to per-window PB.  We need to move the removeDataFromDomain API to its own service before that happens.  That API never really belonged there, and perhaps it makes sense for us to move it to places?
Blocks: 463027
Blocks: 797256
Created attachment 667596 [details] [diff] [review]
Patch (v1)

I put that method in its own JS module, ClearRecentHistory.
Assignee: chrislord.net → ehsan
Status: NEW → ASSIGNED
Attachment #667596 - Flags: review?(josh)
https://tbpl.mozilla.org/?tree=Try&rev=84020ccc0708

Comment 3

5 years ago
Comment on attachment 667596 [details] [diff] [review]
Patch (v1)

Review of attachment 667596 [details] [diff] [review]:
-----------------------------------------------------------------

The contents of removeDataFromDomain are just itching to move to the actual components that own the data, but I'll just file a bug about that some other time.
Attachment #667596 - Flags: review?(josh) → review+
(In reply to comment #3)
> The contents of removeDataFromDomain are just itching to move to the actual
> components that own the data, but I'll just file a bug about that some other
> time.

Well, that stuff should probably get rewritten at some point for performance (by not doing all sorts of terrible sync io on the main thread.  I'm not sure if the refactoring as you suggest it is going to be worth it on its own...

Comment 5

5 years ago
Try run for 84020ccc0708 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=84020ccc0708
Results (out of 13 total builds):
    success: 12
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-84020ccc0708
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d840c9cf30
Target Milestone: --- → Firefox 18
Keywords: addon-compat
Keywords: dev-doc-needed

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/41d840c9cf30
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.