Last Comment Bug 774963 - Move the removeDataFromDomain API into its own service
: Move the removeDataFromDomain API into its own service
Status: RESOLVED FIXED
: addon-compat, dev-doc-needed
Product: Firefox
Classification: Client Software
Component: Private Browsing (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: Firefox 18
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on:
Blocks: PBnGen fxPBnGen
  Show dependency treegraph
 
Reported: 2012-07-17 18:48 PDT by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2012-10-04 09:01 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (77.49 KB, patch)
2012-10-03 12:20 PDT, :Ehsan Akhgari (busy, don't ask for review please)
josh: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2012-07-17 18:48:23 PDT
The private browsing service API will go away when we switch to per-window PB.  We need to move the removeDataFromDomain API to its own service before that happens.  That API never really belonged there, and perhaps it makes sense for us to move it to places?
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2012-10-03 12:20:15 PDT
Created attachment 667596 [details] [diff] [review]
Patch (v1)

I put that method in its own JS module, ClearRecentHistory.
Comment 2 :Ehsan Akhgari (busy, don't ask for review please) 2012-10-03 12:31:34 PDT
https://tbpl.mozilla.org/?tree=Try&rev=84020ccc0708
Comment 3 Josh Matthews [:jdm] 2012-10-03 12:49:36 PDT
Comment on attachment 667596 [details] [diff] [review]
Patch (v1)

Review of attachment 667596 [details] [diff] [review]:
-----------------------------------------------------------------

The contents of removeDataFromDomain are just itching to move to the actual components that own the data, but I'll just file a bug about that some other time.
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2012-10-03 12:52:37 PDT
(In reply to comment #3)
> The contents of removeDataFromDomain are just itching to move to the actual
> components that own the data, but I'll just file a bug about that some other
> time.

Well, that stuff should probably get rewritten at some point for performance (by not doing all sorts of terrible sync io on the main thread.  I'm not sure if the refactoring as you suggest it is going to be worth it on its own...
Comment 5 Mozilla RelEng Bot 2012-10-03 15:15:31 PDT
Try run for 84020ccc0708 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=84020ccc0708
Results (out of 13 total builds):
    success: 12
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/eakhgari@mozilla.com-84020ccc0708
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2012-10-03 15:21:34 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d840c9cf30
Comment 7 Ed Morley [:emorley] 2012-10-04 09:01:16 PDT
https://hg.mozilla.org/mozilla-central/rev/41d840c9cf30

Note You need to log in before you can comment on or make changes to this bug.