774969 - One browser_toolbar.xml to rule them all

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Wesley Johnston (:wesj)]

Glancing at browser_toolbar.xml, it seems like we have three versions that are all basically the same sans some padding/margin/visibility/etc differences. Can we just move those differences into styles and have one browser_toolbar.xml?

If there are places where there are bigger differences, maybe we can use import's to contain them?

Comment 1

[Wesley Johnston (:wesj)]

I have a small workish in progress where I'm doing this piece by piece, but I'm not sure of devices I need to test on. Sriram, can you give me a run down of what you'd trust as a test set?

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Early WIP

There ain't much here, but that doesn't stop me from putting it up.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.