The default bug view has changed. See this FAQ.

IonMonkey: Implement constant folding for StringLength and Compare instructions

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Pericles Alves, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Implement constant folding to StringLength and add evaluation of constant operands to Compare instructions.
(Reporter)

Comment 1

5 years ago
Created attachment 643252 [details] [diff] [review]
Created folding for StringLength and evaluation of constant operands for Compare instructions.
(Reporter)

Updated

5 years ago
Attachment #643252 - Flags: review?(nicolas.b.pierron)
Comment on attachment 643252 [details] [diff] [review]
Created folding for StringLength and evaluation of constant operands for Compare instructions.

Review of attachment 643252 [details] [diff] [review]:
-----------------------------------------------------------------

I have no comment except that this patch is Good and that I will push it tomorrow.

If you want to ask somebody for a review, you can set the review flag to "?" followed by one user email or id ":pierron", bugzilla should auto-complete.  You can set the review flag when you are adding the patch or by clicking the [details] link of the attachment.
Attachment #643252 - Flags: review+
Comment on attachment 643252 [details] [diff] [review]
Created folding for StringLength and evaluation of constant operands for Compare instructions.

Oops, sorry for the previous reply. I was verifying your patch and did not notice that you set the flag while I commented.

Good job :)
Attachment #643252 - Flags: review?(nicolas.b.pierron)
https://hg.mozilla.org/projects/ionmonkey/rev/bef02b378666
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.