Comment 1 Pericles Alves 2012-07-17 20:57:56 PDT

Created attachment 643252 [details] [diff] [review]
Created folding for StringLength and evaluation of constant operands for Compare instructions.

Comment 2 Nicolas B. Pierron [:nbp] 2012-07-17 21:25:16 PDT

Comment on attachment 643252 [details] [diff] [review]
Created folding for StringLength and evaluation of constant operands for Compare instructions.

Review of attachment 643252 [details] [diff] [review]:
-----------------------------------------------------------------

I have no comment except that this patch is Good and that I will push it tomorrow.

If you want to ask somebody for a review, you can set the review flag to "?" followed by one user email or id ":pierron", bugzilla should auto-complete.  You can set the review flag when you are adding the patch or by clicking the [details] link of the attachment.

Comment 3 Nicolas B. Pierron [:nbp] 2012-07-17 21:27:31 PDT

Comment on attachment 643252 [details] [diff] [review]
Created folding for StringLength and evaluation of constant operands for Compare instructions.

Oops, sorry for the previous reply. I was verifying your patch and did not notice that you set the flag while I commented.

Good job :)

Comment 4 Nicolas B. Pierron [:nbp] 2012-07-18 08:50:35 PDT

https://hg.mozilla.org/projects/ionmonkey/rev/bef02b378666