Closed Bug 774974 Opened 13 years ago Closed 13 years ago

IonMonkey: Implement constant folding for StringLength and Compare instructions

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: periclesroalves, Unassigned)

Details

Attachments

(1 file)

Implement constant folding to StringLength and add evaluation of constant operands to Compare instructions.
Attachment #643252 - Flags: review?(nicolas.b.pierron)
Comment on attachment 643252 [details] [diff] [review] Created folding for StringLength and evaluation of constant operands for Compare instructions. Review of attachment 643252 [details] [diff] [review]: ----------------------------------------------------------------- I have no comment except that this patch is Good and that I will push it tomorrow. If you want to ask somebody for a review, you can set the review flag to "?" followed by one user email or id ":pierron", bugzilla should auto-complete. You can set the review flag when you are adding the patch or by clicking the [details] link of the attachment.
Attachment #643252 - Flags: review+
Comment on attachment 643252 [details] [diff] [review] Created folding for StringLength and evaluation of constant operands for Compare instructions. Oops, sorry for the previous reply. I was verifying your patch and did not notice that you set the flag while I commented. Good job :)
Attachment #643252 - Flags: review?(nicolas.b.pierron)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: