774987 - Memory leak and unnecessary copies in PresShell touch-event handling code

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Memory leak

 http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#5559

Unnecessary copies

 http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#6503
 http://mxr.mozilla.org/mozilla-central/source/layout/base/nsPresShell.cpp#6553

(Since nsIDOMTouch is cycle collected, I think these unref's can be relatively expensive.)

Wes, want to grab these?

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

I think this is right?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 643424 [details] [diff] [review]
Patch

Why not 

nsPoint pt(aTouch->mRefPoint.x, aTouch->mRefPoint.y);
widget = frame->GetView()->GetNearestWidget(&pt);

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch v2

I'm fine with that. Tested on Google maps. Everythings still good.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1341ea4e3c80

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1341ea4e3c80