Closed
Bug 774988
Opened 12 years ago
Closed 12 years ago
Use event compression for cross-process events
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: cjones, Assigned: cjones)
References
Details
Attachments
(1 file)
3.56 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Currently we pull them out of the IPC message queue in order. Dispatching each message is relatively costly, and events like mousemove/touchmove can trigger fairly expensive dispatch and get behind, introducing noticeable lag.
We should also use this for repaint requests, since we always want to service the most recent one and never process "stale" ones.
The right way to do this is bug 636063, though now that we have IPDL |union|s we may not need that complex of an API.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: nobody → jones.chris.g
Attachment #654164 -
Flags: review?(bent.mozilla)
Updated•12 years ago
|
Attachment #654164 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
FWIW, Try confirms that this was the patch that caused the problems.
https://tbpl.mozilla.org/?tree=Try&rev=a20416558f75
Bug 636063 by itself:
https://tbpl.mozilla.org/?tree=Try&rev=906939394b03
Assignee | ||
Comment 5•12 years ago
|
||
Try also confirmed that all the patches work fine
https://tbpl.mozilla.org/?tree=Try&rev=6ae17411083c
I guess I can push to try again, but if it comes back green (again), I have no idea what to do.
Assignee | ||
Comment 6•12 years ago
|
||
Also, none of this code runs in native-fennec.
Comment 7•12 years ago
|
||
Unless you'd prefer that I not, I'm going to re-push 636063 and 784647 to inbound in a little bit. Here are the Try runs I did:
https://tbpl.mozilla.org/?tree=Try&rev=906939394b03
https://tbpl.mozilla.org/?tree=Try&rev=a20416558f75
https://tbpl.mozilla.org/?tree=Try&rev=badf339d05ac
https://tbpl.mozilla.org/?tree=Try&rev=eabc0f1e0f2e
Comment 8•12 years ago
|
||
For what it's worth, I did a Try push earlier that passed with all 3. It wasn't until after today's inbound merge that it blew up.
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Ryan VanderMeulen from comment #7)
> Unless you'd prefer that I not, I'm going to re-push 636063 and 784647 to
> inbound in a little bit.
Please do!
It strikes me that one difference between try and inbound is that try will always clobber, though it worries me if that actually does affect the test runs. However, your push to try that failed in the same way doesn't convince me that that's a valid hypothesis.
Assignee | ||
Comment 10•12 years ago
|
||
There is no earthly reason this patch could break native-android tests. I'll do another push to try with latest inbound and see if the planets align differently now.
Assignee | ||
Comment 11•12 years ago
|
||
Another green run on try. Relanded
https://hg.mozilla.org/integration/mozilla-inbound/rev/b543ecb718e3
Comment 12•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•