Last Comment Bug 774988 - Use event compression for cross-process events
: Use event compression for cross-process events
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on: 636063
Blocks: 761933
  Show dependency treegraph
 
Reported: 2012-07-17 22:41 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-08-26 13:06 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Compress touchmove events across processes (3.56 KB, patch)
2012-08-22 03:55 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
bent.mozilla: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-17 22:41:39 PDT
Currently we pull them out of the IPC message queue in order.  Dispatching each message is relatively costly, and events like mousemove/touchmove can trigger fairly expensive dispatch and get behind, introducing noticeable lag.

We should also use this for repaint requests, since we always want to service the most recent one and never process "stale" ones.

The right way to do this is bug 636063, though now that we have IPDL |union|s we may not need that complex of an API.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-22 03:55:54 PDT
Created attachment 654164 [details] [diff] [review]
Compress touchmove events across processes
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 01:26:15 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/196094fe2f7a
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-08-25 12:21:57 PDT
FWIW, Try confirms that this was the patch that caused the problems.
https://tbpl.mozilla.org/?tree=Try&rev=a20416558f75

Bug 636063 by itself:
https://tbpl.mozilla.org/?tree=Try&rev=906939394b03
Comment 5 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 12:23:48 PDT
Try also confirmed that all the patches work fine

https://tbpl.mozilla.org/?tree=Try&rev=6ae17411083c

I guess I can push to try again, but if it comes back green (again), I have no idea what to do.
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 12:28:23 PDT
Also, none of this code runs in native-fennec.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-08-25 12:32:18 PDT
Unless you'd prefer that I not, I'm going to re-push 636063 and 784647 to inbound in a little bit. Here are the Try runs I did:

https://tbpl.mozilla.org/?tree=Try&rev=906939394b03
https://tbpl.mozilla.org/?tree=Try&rev=a20416558f75
https://tbpl.mozilla.org/?tree=Try&rev=badf339d05ac
https://tbpl.mozilla.org/?tree=Try&rev=eabc0f1e0f2e
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-25 12:33:00 PDT
For what it's worth, I did a Try push earlier that passed with all 3. It wasn't until after today's inbound merge that it blew up.
Comment 9 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 12:37:45 PDT
(In reply to Ryan VanderMeulen from comment #7)
> Unless you'd prefer that I not, I'm going to re-push 636063 and 784647 to
> inbound in a little bit.

Please do!

It strikes me that one difference between try and inbound is that try will always clobber, though it worries me if that actually does affect the test runs.  However, your push to try that failed in the same way doesn't convince me that that's a valid hypothesis.
Comment 10 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 15:45:00 PDT
There is no earthly reason this patch could break native-android tests.  I'll do another push to try with latest inbound and see if the planets align differently now.
Comment 11 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-25 17:48:15 PDT
Another green run on try.  Relanded

https://hg.mozilla.org/integration/mozilla-inbound/rev/b543ecb718e3
Comment 12 Ryan VanderMeulen [:RyanVM] 2012-08-26 13:06:29 PDT
https://hg.mozilla.org/mozilla-central/rev/b543ecb718e3

Note You need to log in before you can comment on or make changes to this bug.