The default bug view has changed. See this FAQ.

Use event compression for cross-process events

RESOLVED FIXED in mozilla17

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently we pull them out of the IPC message queue in order.  Dispatching each message is relatively costly, and events like mousemove/touchmove can trigger fairly expensive dispatch and get behind, introducing noticeable lag.

We should also use this for repaint requests, since we always want to service the most recent one and never process "stale" ones.

The right way to do this is bug 636063, though now that we have IPDL |union|s we may not need that complex of an API.
Blocks: 761933
Created attachment 654164 [details] [diff] [review]
Compress touchmove events across processes
Assignee: nobody → jones.chris.g
Attachment #654164 - Flags: review?(bent.mozilla)
Attachment #654164 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/196094fe2f7a
https://hg.mozilla.org/integration/mozilla-inbound/rev/941fff75a9e7
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ee8dd0d4bd7
FWIW, Try confirms that this was the patch that caused the problems.
https://tbpl.mozilla.org/?tree=Try&rev=a20416558f75

Bug 636063 by itself:
https://tbpl.mozilla.org/?tree=Try&rev=906939394b03
Try also confirmed that all the patches work fine

https://tbpl.mozilla.org/?tree=Try&rev=6ae17411083c

I guess I can push to try again, but if it comes back green (again), I have no idea what to do.
Also, none of this code runs in native-fennec.
Unless you'd prefer that I not, I'm going to re-push 636063 and 784647 to inbound in a little bit. Here are the Try runs I did:

https://tbpl.mozilla.org/?tree=Try&rev=906939394b03
https://tbpl.mozilla.org/?tree=Try&rev=a20416558f75
https://tbpl.mozilla.org/?tree=Try&rev=badf339d05ac
https://tbpl.mozilla.org/?tree=Try&rev=eabc0f1e0f2e
For what it's worth, I did a Try push earlier that passed with all 3. It wasn't until after today's inbound merge that it blew up.
(In reply to Ryan VanderMeulen from comment #7)
> Unless you'd prefer that I not, I'm going to re-push 636063 and 784647 to
> inbound in a little bit.

Please do!

It strikes me that one difference between try and inbound is that try will always clobber, though it worries me if that actually does affect the test runs.  However, your push to try that failed in the same way doesn't convince me that that's a valid hypothesis.
There is no earthly reason this patch could break native-android tests.  I'll do another push to try with latest inbound and see if the planets align differently now.
Another green run on try.  Relanded

https://hg.mozilla.org/integration/mozilla-inbound/rev/b543ecb718e3
https://hg.mozilla.org/mozilla-central/rev/b543ecb718e3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.