774990 - Copying a profile with a disabled restartless add-on to a different directory causes extensions to fail to load

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[al_9x]

the error log shows:

Timestamp: 7/18/2012 2:03:34 AM
Error: ERROR addons.xpi: Error processing file changes: TypeError: bootstrap is undefined
Source File: resource:///modules/XPIProvider.jsm
Line: 2412

Could not read chrome manifest 'old jar absolute path'. <- for every extension

the a bunch of these for many resources of various extensions:

No chrome package registered for chrome://tabmixplus/content/overlay/browsroverlay40.css

restarting Fx once or twice, fixes the problem, but this worked flawlessly before 15

Comment 1

[al_9x]

This is caused by a disabled firebug 1.10, without it, or if enabled, there is no problem after copying

Comment 2

[al_9x]

But Fx 15 is a factor, no problem in 14

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to al_9x from comment #1)
> This is caused by a disabled firebug 1.10, without it, or if enabled, there
> is no problem after copying
I don't understand this. If Firebug is disabled how it could cause the problem?
Does it mean that it's Firefox issue?

Honza

Comment 4

[Wladimir Palant]

Yes, the bug description clearly indicates that extensions.ini didn't get updated - that would be a Firefox issue.

Comment 5

[al_9x]

I don't understand either, but it's consistent.

@Wladimir - I cced you because you recently blogged about restartless extensions.  This seems to have something to do with that.  In fact the same thing happens with a disabled abp instead of firebug.  It's as if Fx tries to call into the disabled restartless extension on first start after copying, expecting it to do something, which it doesn't.

Comment 6

[Dave Townsend [:mossop]]

Does this happen with 16 or 17?

Comment 7

[Dave Townsend [:mossop]]

Nevermind, looks like this is some kind of regression caused by bug 744833

Comment 8

[Dave Townsend [:mossop]]

How are you copying the profile files? Is there any chance that prefs.js isn't included in the copy, since that would probably cause this issue.

Comment 9

[al_9x]

everything is copied

Comment 10

[Dave Townsend [:mossop]]

This happens whenever there is a disabled restartless add-on in the profile.

Comment 11

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Silly mistake here, if the add-on is disabled then it won't be in bootstrappedAddons so everything goes horribly wrong.

Comment 12

[Dave Townsend [:mossop]]

On inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2285d68618

Once it passes a few days on nightly I'll see about getting it pushed to aurora and beta.

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ef2285d68618

Comment 14

[Dave Townsend [:mossop]]

Comment on attachment 644021 [details] [diff] [review]
patch rev 1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 744833
User impact if declined: it's a rare case so few users will see the issue, but it is also a very safe and simple fix.
Testing completed (on m-c, etc.): m-c for a few days, it's not a common path though so the automated testing are our main source of testing here
Risk to taking this patch (and alternatives if risky): extremely safe
String or UUID changes made by this patch: none

Comment 15

[Alex Keybl [:akeybl]]

Comment on attachment 644021 [details] [diff] [review]
patch rev 1

[Triage Comment]
Since we're still early in the beta cycle, and this is a low risk FF15 regression fix, let's take the fix even though it's likely to be a rare user issue.

Comment 16

[Dave Townsend [:mossop]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/11d7c076de51
https://hg.mozilla.org/releases/mozilla-beta/rev/d11eb233d8ec

Comment 17

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0

Verified in Firefox 15 beta3 after copying profile with Firebug disabled. No extension.log.