774991 - Stop support OSX 10.5 (buildbot configs) in SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Release Engineering, defect)

Description

[Edmund Wong (:ewong)]

From bug #773120, FireFox will turn of support for OSX 10.5 in FireFox 17.

We need to do the same with SeaMonkey 2.14.

1) Turn off OSX 10.5 tests.
2) Remove OSX 10.5 from build configs.

Comment 1

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #0)
> From bug #773120, FireFox will turn of support for OSX 10.5 in FireFox 17.
> 
> We need to do the same with SeaMonkey 2.14.
> 
> 1) Turn off OSX 10.5 tests.
> 2) Remove OSX 10.5 from build configs.

Further clarification:

3) Stop updates to 10.5.
4) Explicitly state the removal of support in public (via website, ngs)
5) Once removal of 10.5 has been propagated to -release,
   decommission the 10.5 OS and have them replaced with the newer 10.6.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug from comm-central platforms to disable building on them on trunk. (v1)

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 649186 [details] [diff] [review]
Remove macosx/macosx-debug from comm-central platforms to disable building on them on trunk. (v1)

Review of attachment 649186 [details] [diff] [review]:
-----------------------------------------------------------------

This *looks* right, I'd be interested in the output of dump-master before and after this single patch though. (will be convoluted I'm sure)

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 649186 [details] [diff] [review]
Remove macosx/macosx-debug from comm-central platforms to disable building on them on trunk. (v1)

Review of attachment 649186 [details] [diff] [review]:
-----------------------------------------------------------------

...holding out on this review until after the release when I can do a dump_master on our master without potentially interupting a release

Comment 5

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug from comm-central platforms to disable building on them on Aurora. (v1)

Comment 6

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug from comm-central platforms to disable building on them on Beta. (v1)

When time comes, this patch (when reviewed) will be applied to the configs.

Comment 7

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug from comm-central platforms to disable building on them on Release. (v1)

Comment 8

[Justin Wood (:Callek)]

Looks like I intirely forgot the AUS needs for this, I just applied https://bugzilla.mozilla.org/attachment.cgi?id=640908 (from Bug 772735) to our aus server, with our ver 2.14a1+ listed. We should no longer be offering any OSX 10.5 users updates (albeit a bit late)

Comment 9

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug from all builds. (v1)

Comment 10

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v2)

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 697364 [details] [diff] [review]
Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v2)

Review of attachment 697364 [details] [diff] [review]:
-----------------------------------------------------------------

Additional files that need love:
* buildbot-configs\seamonkey\l10nbuilds.ini
-- This file contains the actual full l10n buildername we need to delete that for macosx on the varying lines (I forget what, if anything, still uses that file, but I'd rather be safe than sorry)

* buildbot-configs\seamonkey\master.cfg
* buildbot-configs\seamonkey\release-comm-1.9.1.py
* buildbot-configs\seamonkey\release-comm-2.0.py
-- Has refs that need to be removed

* buildbot-configs\seamonkey\release_master.py
-- Needs to rip out:
---- if releaseConfig['sourceRepoName'] == 'comm-1.9.1':
----       verifySlavePlat = 'macosx'

Without locally applying it I'm also going to trust all these deleted files are all the macosx directory, and no stragglers remain there for mozconfigs.

r- for the listed reasons, but f+ because it looks good overall.
Lets get a new patch up, I'll review fast and we can land.

::: seamonkey/config.py
@@ -1,1 @@
>  from copy import deepcopy

In this file as well, please remove 'macosx' from line 461 (marked with # below)

    'comm-1.9.1': {'platforms': {
            'linux': {},
            'linux64': {},
            'win32': {},
#           'macosx': {},
        }},

@@ -1,2 @@
>  from copy import deepcopy
>  

Similar for lines for BRANCHES['comm-2.0'] and BRANCHES['comm-1.9.1'] etc below in this file

(it appears at a glance this patch was made against your patch where those branches were removed, but I don't see THAT patch in my queue anymore)

Comment 12

[Edmund Wong (:ewong)]

Attachment: Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v3)

Comment 13

[Robert Kaiser]

(In reply to Justin Wood (:Callek) from comment #11)
> Similar for lines for BRANCHES['comm-2.0'] and BRANCHES['comm-1.9.1'] etc
> below in this file
> 
> (it appears at a glance this patch was made against your patch where those
> branches were removed, but I don't see THAT patch in my queue anymore)

Hehe, yes, when I read this, I immediately thought "What? We still got comm-2.0 and comm-1.9.1 in our configs? Those oughta die!" ;-)

Comment 14

[Justin Wood (:Callek)]

Comment on attachment 708017 [details] [diff] [review]
Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v3)

Review of attachment 708017 [details] [diff] [review]:
-----------------------------------------------------------------

To be extra careful, lets land and deploy this only after our 2.15.2 ships

Comment 15

[Edmund Wong (:ewong)]

Pushed to buildbot-configs: (seamonkey-production)
http://hg.mozilla.org/build/buildbot-configs/rev/1e7b2fc1cb97

Comment 16

[Edmund Wong (:ewong)]

Jumped the gun.  There's more to this bug aside for buildbot config
changes.

Comment 17

[Edmund Wong (:ewong)]

Morphed this bug to be for the buildbot changes patch.  The tracking
bug has been filed as bug 837649.