Closed Bug 774991 Opened 8 years ago Closed 7 years ago

Stop support OSX 10.5 (buildbot configs) in SeaMonkey

Categories

(SeaMonkey :: Release Engineering, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

References

Details

Attachments

(1 file, 6 obsolete files)

From bug #773120, FireFox will turn of support for OSX 10.5 in FireFox 17.

We need to do the same with SeaMonkey 2.14.

1) Turn off OSX 10.5 tests.
2) Remove OSX 10.5 from build configs.
OS: Windows Vista → All
(In reply to Edmund Wong (:ewong) from comment #0)
> From bug #773120, FireFox will turn of support for OSX 10.5 in FireFox 17.
> 
> We need to do the same with SeaMonkey 2.14.
> 
> 1) Turn off OSX 10.5 tests.
> 2) Remove OSX 10.5 from build configs.

Further clarification:

3) Stop updates to 10.5.
4) Explicitly state the removal of support in public (via website, ngs)
5) Once removal of 10.5 has been propagated to -release,
   decommission the 10.5 OS and have them replaced with the newer 10.6.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Summary: stop support OSX 10.5 in SeaMonkey → [Tracking bug] stop support OSX 10.5 in SeaMonkey
Comment on attachment 649186 [details] [diff] [review]
Remove macosx/macosx-debug from comm-central platforms to disable building on them on trunk. (v1)

Review of attachment 649186 [details] [diff] [review]:
-----------------------------------------------------------------

This *looks* right, I'd be interested in the output of dump-master before and after this single patch though. (will be convoluted I'm sure)
Attachment #649186 - Flags: feedback+
Comment on attachment 649186 [details] [diff] [review]
Remove macosx/macosx-debug from comm-central platforms to disable building on them on trunk. (v1)

Review of attachment 649186 [details] [diff] [review]:
-----------------------------------------------------------------

...holding out on this review until after the release when I can do a dump_master on our master without potentially interupting a release
When time comes, this patch (when reviewed) will be applied to the configs.
Attachment #677981 - Flags: review?(bugspam.Callek)
Looks like I intirely forgot the AUS needs for this, I just applied https://bugzilla.mozilla.org/attachment.cgi?id=640908 (from Bug 772735) to our aus server, with our ver 2.14a1+ listed. We should no longer be offering any OSX 10.5 users updates (albeit a bit late)
Attachment #649186 - Attachment is obsolete: true
Attachment #675434 - Attachment is obsolete: true
Attachment #677981 - Attachment is obsolete: true
Attachment #677983 - Attachment is obsolete: true
Attachment #649186 - Flags: review?(bugspam.Callek)
Attachment #675434 - Flags: review?(bugspam.Callek)
Attachment #677981 - Flags: review?(bugspam.Callek)
Attachment #677983 - Flags: review?(bugspam.Callek)
Attachment #697359 - Flags: review?(bugspam.Callek)
Attachment #697359 - Attachment is obsolete: true
Attachment #697359 - Flags: review?(bugspam.Callek)
Attachment #697364 - Flags: review?(bugspam.Callek)
Attachment #697364 - Attachment description: Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v1) → Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v2)
Comment on attachment 697364 [details] [diff] [review]
Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v2)

Review of attachment 697364 [details] [diff] [review]:
-----------------------------------------------------------------

Additional files that need love:
* buildbot-configs\seamonkey\l10nbuilds.ini
-- This file contains the actual full l10n buildername we need to delete that for macosx on the varying lines (I forget what, if anything, still uses that file, but I'd rather be safe than sorry)

* buildbot-configs\seamonkey\master.cfg
* buildbot-configs\seamonkey\release-comm-1.9.1.py
* buildbot-configs\seamonkey\release-comm-2.0.py
-- Has refs that need to be removed

* buildbot-configs\seamonkey\release_master.py
-- Needs to rip out:
---- if releaseConfig['sourceRepoName'] == 'comm-1.9.1':
----       verifySlavePlat = 'macosx'

Without locally applying it I'm also going to trust all these deleted files are all the macosx directory, and no stragglers remain there for mozconfigs.

r- for the listed reasons, but f+ because it looks good overall.
Lets get a new patch up, I'll review fast and we can land.

::: seamonkey/config.py
@@ -1,1 @@
>  from copy import deepcopy

In this file as well, please remove 'macosx' from line 461 (marked with # below)

    'comm-1.9.1': {'platforms': {
            'linux': {},
            'linux64': {},
            'win32': {},
#           'macosx': {},
        }},

@@ -1,2 @@
>  from copy import deepcopy
>  

Similar for lines for BRANCHES['comm-2.0'] and BRANCHES['comm-1.9.1'] etc below in this file

(it appears at a glance this patch was made against your patch where those branches were removed, but I don't see THAT patch in my queue anymore)
Attachment #697364 - Flags: review?(bugspam.Callek)
Attachment #697364 - Flags: review-
Attachment #697364 - Flags: feedback+
Attachment #697364 - Attachment is obsolete: true
Attachment #708017 - Flags: review?(bugspam.Callek)
(In reply to Justin Wood (:Callek) from comment #11)
> Similar for lines for BRANCHES['comm-2.0'] and BRANCHES['comm-1.9.1'] etc
> below in this file
> 
> (it appears at a glance this patch was made against your patch where those
> branches were removed, but I don't see THAT patch in my queue anymore)

Hehe, yes, when I read this, I immediately thought "What? We still got comm-2.0 and comm-1.9.1 in our configs? Those oughta die!" ;-)
Comment on attachment 708017 [details] [diff] [review]
Remove macosx/macosx-debug (and mozconfig dirs) from all builds. (v3)

Review of attachment 708017 [details] [diff] [review]:
-----------------------------------------------------------------

To be extra careful, lets land and deploy this only after our 2.15.2 ships
Attachment #708017 - Flags: review?(bugspam.Callek) → review+
Pushed to buildbot-configs: (seamonkey-production)
http://hg.mozilla.org/build/buildbot-configs/rev/1e7b2fc1cb97
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Jumped the gun.  There's more to this bug aside for buildbot config
changes.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Blocks: 837649
Summary: [Tracking bug] stop support OSX 10.5 in SeaMonkey → Stop support OSX 10.5 (buildbot configs) in SeaMonkey
Morphed this bug to be for the buildbot changes patch.  The tracking
bug has been filed as bug 837649.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.