Closed
Bug 775010
Opened 12 years ago
Closed 12 years ago
autocomplete.css is not preprocessed on Windows XP
Categories
(Firefox :: Address Bar, defect)
Tracking
()
RESOLVED
FIXED
Firefox 17
Tracking | Status | |
---|---|---|
firefox16 | --- | fixed |
People
(Reporter: ahurle, Assigned: ahurle)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
MattN
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
bug 758354 stopped preprocessing autocomplete.css, but bug 587909 now needs that file to be preprocessed on XP. Wasn't caught after rebasing. Consequently, results in XP are a bit closer together than intended and the highlight style is different.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #643285 -
Flags: review?(mnoorenberghe+bmo)
Updated•12 years ago
|
Attachment #643285 -
Flags: review?(mnoorenberghe+bmo) → review+
Comment 2•12 years ago
|
||
status-firefox16:
--- → affected
Flags: in-testsuite-
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Comment 4•12 years ago
|
||
I assume you're going to land this on aurora?
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 587909, bug 758354
User impact if declined: Awesomebar results would be harder to read for XP users because they're closer together. Fix would land a version later in Firefox 17.
Testing completed (on m-c, etc.): Yes, see m-c/m-i pushes above
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None
Attachment #643285 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Comment on attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css
[Triage Comment]
Styling fix and very early in the cycle, approved for Aurora 16.
Attachment #643285 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•