775010 - autocomplete.css is not preprocessed on Windows XP

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Andrew Hurle [:ahurle]]

bug 758354 stopped preprocessing autocomplete.css, but bug 587909 now needs that file to be preprocessed on XP.  Wasn't caught after rebasing.  Consequently, results in XP are a bit closer together than intended and the highlight style is different.

Comment 1

[Andrew Hurle [:ahurle]]

Attachment: Very intricate patch to preprocess autocomplete.css

Comment 2

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce577fd16506

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ce577fd16506

Comment 4

[Dão Gottwald [:dao]]

I assume you're going to land this on aurora?

Comment 5

[Andrew Hurle [:ahurle]]

Comment on attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 587909, bug 758354
User impact if declined: Awesomebar results would be harder to read for XP users because they're closer together.  Fix would land a version later in Firefox 17.
Testing completed (on m-c, etc.): Yes, see m-c/m-i pushes above
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css

[Triage Comment]
Styling fix and very early in the cycle, approved for Aurora 16.

Comment 7

[Matthew N. [:MattN]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/078b300be5ef