autocomplete.css is not preprocessed on Windows XP

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Location Bar
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ahurle, Assigned: ahurle)

Tracking

Trunk
Firefox 17
All
Windows XP
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bug 758354 stopped preprocessing autocomplete.css, but bug 587909 now needs that file to be preprocessed on XP.  Wasn't caught after rebasing.  Consequently, results in XP are a bit closer together than intended and the highlight style is different.
(Assignee)

Comment 1

5 years ago
Created attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css
Attachment #643285 - Flags: review?(mnoorenberghe+bmo)
Attachment #643285 - Flags: review?(mnoorenberghe+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce577fd16506
status-firefox16: --- → affected
Flags: in-testsuite-

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ce577fd16506
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
I assume you're going to land this on aurora?
(Assignee)

Comment 5

5 years ago
Comment on attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 587909, bug 758354
User impact if declined: Awesomebar results would be harder to read for XP users because they're closer together.  Fix would land a version later in Firefox 17.
Testing completed (on m-c, etc.): Yes, see m-c/m-i pushes above
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None
Attachment #643285 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Comment on attachment 643285 [details] [diff] [review]
Very intricate patch to preprocess autocomplete.css

[Triage Comment]
Styling fix and very early in the cycle, approved for Aurora 16.
Attachment #643285 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/078b300be5ef
status-firefox16: affected → fixed
You need to log in before you can comment on or make changes to this bug.