775051 - B2g pref loading / parsing causing mochitests to not load

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[[e-mail] [:onecyrenus]]

Attachment: b2g patch

Basically if the 'b2g.privileged.domains' pref is not set in prefs.js I was noticing a problem loading mochitests. 

The reason is generally split returns one element and we are attempting to addPermissions for what is an empty string, without appropriate protections inside addPermsissions. 



    let domains = "";
    try {
      domains = Services.prefs.getCharPref('b2g.privileged.domains');
    } catch(e) {}

    addPermissions(domains.split(","));

Comment 1

[Jonathan Griffin (:jgriffin)]

Comment on attachment 643318 [details] [diff] [review]
b2g patch

The alternative is to add some dummy domains to the pref in the mochitest test profile.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 643318 [details] [diff] [review]
b2g patch

Review of attachment 643318 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.js
@@ +62,3 @@
>    urls.forEach(function(url) {
>      url = url.trim();
> +    if (url.length > 0 ) {

Could just be `if (url.length)` or even `if (url)`.

Looks good otherwise.

Comment 3

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7bd1d5c84bea

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7bd1d5c84bea