775186 - IonMonkey: Change polymorphic inlining to use single instruction instead of chained guards

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

Poly inlining as currently implemented uses a chain of guard blocks - each guard block terminated with an InlineFunctionGuard instruction leading to either the inlined function entry, or to the next guard (or the final inlined function in the case of the final guard).

This approach is hard to reconcile with future changes we want to make to polymorphic inlining, including fusing of poly ICs with poly inlining (Bug 770309) and fallback paths for poly inlining (Bug 772049).

Change poly inlining implementation to use a single IR instruction to perform all guards and dispatch to the different inlined function entry blocks.

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Add PolyInlineDispatch instruction

These patches were already posted and r+-ed in Bug 770309.  Just re-posting with edits here.

Comment 2

[Kannan Vijayan [:djvj]]

Attachment: Change IonBuilder to use PolyInlineDispatch instruction.

Comment 3

[Kannan Vijayan [:djvj]]

Attachment: Remove InlineFunctionGuard instruction.

Comment 4

[Paul Wright]

Is this done (FIXED)?

Comment 5

[Kannan Vijayan [:djvj]]

It's checked in to the Ion branch.  I was just waiting on tbpl before closing.