775318 - Make text stand out better for accessibility users

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[David Weir (satdav)]

Hello guys can i suggest what all text gets bold or on a darker kind of black as per applies on the following 

http://www.w3.org/TR/WCAG/

for example Signature and all of the other text on it and the bar at the top

Comment 1

[David Weir (satdav)]

can i get a update on this bug

Comment 2

[David Weir (satdav)]

Any status update

Comment 3

[Matt Brandt [:mbrandt]]

Assigning to espressive -- what do think? socorro future?

Comment 4

[David Weir (satdav)]

should of made the links bold on github

https://github.com/mozilla/socorro-crashstats/pull/144/files

Comment 5

[Schalk Neethling [:espressive]]

We can make this change but, will implement it in a different way. Do we still want this?

Comment 6

[David Weir (satdav)]

if possible can we do it vie css

Comment 7

[Schalk Neethling [:espressive]]

:satdav Yep, that was how I was planning on implementing it. I will make this change and open a PR.

Comment 8

[David Weir (satdav)]

will this be on the new site and the current one 

as i know you are going to be adding a django based site soon i believe

Comment 9

[Schalk Neethling [:espressive]]

David, this will only be on the new Django based site, as the old one will very soon be retired and replaced by this one.

Comment 10

[Schalk Neethling [:espressive]]

Attachment: font changes for footer

Is this what is referred to by the bug? I might have gotten things confused but, I remember this being about the links in the footer. Is this referring to more than just those?

If so, I reckon the bug description needs to be more specific. Thanks!

Comment 11

[[DEACTIVATED] Adrian Gaudebert]

What is the point of making all texts bold? That just makes it even harder to read. Maybe we could just make the font darker? As I read it, it is currently #333. What if we make it pure black?

Comment 12

[Schalk Neethling [:espressive]]

(In reply to Adrian Gaudebert [:adrian] from comment #11)
> What is the point of making all texts bold? That just makes it even harder
> to read. Maybe we could just make the font darker? As I read it, it is
> currently #333. What if we make it pure black?

I agree Adrian, also the request is a little confusing as it seems in the bug that it is with regards to all text on the site but, the PR referenced only relates to the footer links.

So, we can change the base font color to #000 (pure black) but, this will not have much of an effect in general and no effect on the links in the footer as they are styled separately as a darkish blue.

So, I suppose I can change the base font color to pure black and then perhaps make the links in the footer black as well, but not bold. Thoughts?

Comment 13

[David Weir (satdav)]

would be better as bold as then they stand out better

Comment 14

[Robert Helmer [:rhelmer]]

We might want to address accessibility more systematically rather than doing it piecemeal.. perhaps we should look into general guidelines for font and text colors and apply that globally via CSS?

I would expect that Socorro does not meet a lot of accessibility standards but we could probably explore meeting some of the basics, and not have to make it up as we go along :)

Comment 15

[Schalk Neethling [:espressive]]

(In reply to Robert Helmer [:rhelmer] from comment #14)
> We might want to address accessibility more systematically rather than doing
> it piecemeal.. perhaps we should look into general guidelines for font and
> text colors and apply that globally via CSS?

I agree Rob but, there are some limitations placed on what can be done based on some of the design aspects of the current site in terms of background colors etc. for example, you can see what I presented in comment https://bugzilla.mozilla.org/show_bug.cgi?id=775318#c10 does not really solve much and in fact makes the text less legible.

I would definitely advocate for us taking accessibility serious and therefore do a proper investigation of where things fall short and make a larger, focused effort to resolve the issues.

Comment 16

[David Weir (satdav)]

Mmsle all text darker to pure black

Comment 17

[David Weir (satdav)]

can you possible take a screenshot of the new text on breakpad

Comment 18

[Schalk Neethling [:espressive]]

(In reply to David Weir (satdav) from comment #17)
> can you possible take a screenshot of the new text on breakpad

No changes has been made to the text on crashstats as yet, this is on the to-do list though.

Comment 19

[David Bolter [:davidb] (NeedInfo me for attention)]

Note I use this for contrast checking:
https://addons.mozilla.org/en-us/firefox/addon/wcag-contrast-checker/

Comment 20

[David Weir (satdav)]

can you possible update this bug as it looks like it has not been fixed

Comment 21

[Matt Brandt [:mbrandt]]

Adding needsmoreinfo and adding bug 721518 as blocked instead of dependent. I might be incorrect but I think that is more correct. Bug 721518 looks like a tracker for satdav's investigation work across all Mozilla web domains.

Comment 22

[Schalk Neethling [:espressive]]

https://bugzilla.mozilla.org/show_bug.cgi?id=916743#c2

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c22d8d4a35398778e8daf0d60765307288f53abe
Fix Bug 916743, ensure proper color ratios

https://github.com/mozilla/socorro/commit/be27e160ba5bb37997d781677332bad2c1191b28
Merge pull request #1513 from ossreleasefeed/bug916743-fix-contrast-ratios

Fix Bug 916743, ensure proper color ratios

Comment 23

[Schalk Neethling [:espressive]]

I was actually thinking of marking this qa- but, the basics of the change is this. I fixed the contrast ratios between background color and the foreground text in order to improve a11y. Therefore the only thing to check is basically whether you agree with the change ;)

This is the bigger related bug https://bugzilla.mozilla.org/show_bug.cgi?id=916743 which I mark as qa- so, we can either also mark this one as such or make both qa+ and the testing criteria will be the same.

Comment 24

[David Weir (satdav)]

found a possible bug but its fine to go 
    Signature Summary
    Graph
    Table
    Reports
    Bugzilla (0)
    Comments (2)
    Correlations
 

can we make them a bit darker thats the only thing we need to be done

Comment 25

[Matt Brandt [:mbrandt]]

Bumping to qa verified per comment 24 - satdav will file a new bug for the observations in comment 24.