Add long long template to ipc_message_utils.h for OpenBSD/64bits

RESOLVED FIXED in mozilla17

Status

()

Core
IPC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

Trunk
mozilla17
x86_64
OpenBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Followup to bug #745148 part 7 (https://hg.mozilla.org/mozilla-central/rev/100fd0a81f9e), my OpenBSD/amd64 (and sparc64) builds started failing with the following vomit :

ipc/chromium/src/chrome/common/ipc_message_utils.h: In function 'void IPC::WriteParam(IPC::Message*, const P&) [with P = long long int]':
../../ipc/ipdl/_ipdlheaders/mozilla/layers/PLayersParent.h:295:   instantiated from 'void mozilla::layers::PLayersParent::Write(const T&, IPC::Message*) [with T = long long int]'
ipc/ipdl/PLayersParent.cpp:2455:   instantiated from here
ipc/chromium/src/chrome/common/ipc_message_utils.h:74: error: 'Write' is not a member of 'IPC::ParamTraits<long long int>'
ipc/chromium/src/chrome/common/ipc_message_utils.h: In function 'bool IPC::ReadParam(const IPC::Message*, void**, P*) [with P = int64_t]':
../../ipc/ipdl/_ipdlheaders/mozilla/layers/PLayersParent.h:305:   instantiated from 'bool mozilla::layers::PLayersParent::Read(T*, const IPC::Message*, void**) [with T = int64_t]'
ipc/ipdl/PLayersParent.cpp:2464:   instantiated from here
ipc/chromium/src/chrome/common/ipc_message_utils.h:80: error: 'Read' is not a member of 'IPC::ParamTraits<long long int>'

(see for example end of http://buildbot.rhaalovely.net/builders/comm-central-amd64/builds/429/steps/build/logs/stdio)

On OpenBSD, int64_t is long long (see bug #648735 comment 27), we already have an unsigned long long template for OpenBSD/64 bits, time to add a long long template.. 32 bits builds are okay but i suppose one of the other templates satisfies the long long type (maybe size_t).
(Assignee)

Comment 1

5 years ago
Created attachment 643758 [details] [diff] [review]
Add long long template on OpenBSD/64 bits

Fixes the build for me on OpenBSD/amd64.
Assignee: nobody → landry
Attachment #643758 - Flags: review?(jones.chris.g)
Attachment #643758 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/4b6646e5a368

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/4b6646e5a368
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.