Last Comment Bug 775428 - Add long long template to ipc_message_utils.h for OpenBSD/64bits
: Add long long template to ipc_message_utils.h for OpenBSD/64bits
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: x86_64 OpenBSD
: -- normal (vote)
: mozilla17
Assigned To: Landry Breuil (:gaston)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-19 00:57 PDT by Landry Breuil (:gaston)
Modified: 2012-07-20 06:44 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add long long template on OpenBSD/64 bits (1.65 KB, patch)
2012-07-19 00:59 PDT, Landry Breuil (:gaston)
cjones.bugs: review+
Details | Diff | Splinter Review

Description Landry Breuil (:gaston) 2012-07-19 00:57:35 PDT
Followup to bug #745148 part 7 (https://hg.mozilla.org/mozilla-central/rev/100fd0a81f9e), my OpenBSD/amd64 (and sparc64) builds started failing with the following vomit :

ipc/chromium/src/chrome/common/ipc_message_utils.h: In function 'void IPC::WriteParam(IPC::Message*, const P&) [with P = long long int]':
../../ipc/ipdl/_ipdlheaders/mozilla/layers/PLayersParent.h:295:   instantiated from 'void mozilla::layers::PLayersParent::Write(const T&, IPC::Message*) [with T = long long int]'
ipc/ipdl/PLayersParent.cpp:2455:   instantiated from here
ipc/chromium/src/chrome/common/ipc_message_utils.h:74: error: 'Write' is not a member of 'IPC::ParamTraits<long long int>'
ipc/chromium/src/chrome/common/ipc_message_utils.h: In function 'bool IPC::ReadParam(const IPC::Message*, void**, P*) [with P = int64_t]':
../../ipc/ipdl/_ipdlheaders/mozilla/layers/PLayersParent.h:305:   instantiated from 'bool mozilla::layers::PLayersParent::Read(T*, const IPC::Message*, void**) [with T = int64_t]'
ipc/ipdl/PLayersParent.cpp:2464:   instantiated from here
ipc/chromium/src/chrome/common/ipc_message_utils.h:80: error: 'Read' is not a member of 'IPC::ParamTraits<long long int>'

(see for example end of http://buildbot.rhaalovely.net/builders/comm-central-amd64/builds/429/steps/build/logs/stdio)

On OpenBSD, int64_t is long long (see bug #648735 comment 27), we already have an unsigned long long template for OpenBSD/64 bits, time to add a long long template.. 32 bits builds are okay but i suppose one of the other templates satisfies the long long type (maybe size_t).
Comment 1 Landry Breuil (:gaston) 2012-07-19 00:59:55 PDT
Created attachment 643758 [details] [diff] [review]
Add long long template on OpenBSD/64 bits

Fixes the build for me on OpenBSD/amd64.
Comment 3 Ed Morley [:emorley] 2012-07-20 06:44:14 PDT
https://hg.mozilla.org/mozilla-central/rev/4b6646e5a368

Note You need to log in before you can comment on or make changes to this bug.