775608 - Debugger cannot distinguish multiple inline html scripts on the same line

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

If you have

  <script>console.log(1)</script><script>console.log(2)</script>

there are two distinct scripts on the page, but both will be stored in the same place on ThreadActor's _scripts property, meaning that one will overwrite the other and the debugger will only know about the existence of one of the scripts.

Comment 1

[Rob Campbell [:rc] (:robcee)]

nice catch, Nick.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

This requires Debugger API and protocol support. I thought that I could use script.getLineOffsets as a workaround, but that won't do. Passing a startColumn along with the existing startLine property in the protocol should suffice, I think.

Test page at: http://htmlpad.org/two-scripts-same-line/

Should this depend on bug 568142 or bug 757188?

Comment 3

[Jim Blandy :jimb]

(In reply to Panos Astithas [:past] from comment #2)
> Should this depend on bug 568142 or bug 757188?

Bug 757188, as that one depends on 568142.

Comment 4

[Jason Laster [:jlast]]

This is now fixed after brian's refactoring in the server.