775620 - Migrate fennec builds to mock slaves

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Comment 1

[Chris AtLee [:catlee]]

Attachment: switch to mock!

Comment 2

[Chris AtLee [:catlee]]

Attachment: use builder's environment for sendchange

this is required to get buildbot in the path.

another option would be to change the environment buildbot runs inside of to make sure /tools/buildbot/bin is in PATH on these slaves.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 643963 [details] [diff] [review]
use builder's environment for sendchange

Review of attachment 643963 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine to me.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 643959 [details] [diff] [review]
switch to mock!

Looks like the patch breaks the signing.

Comment 5

[Chris Cooper [:coop] (he/him)]

Comment on attachment 643959 [details] [diff] [review]
switch to mock!

Review of attachment 643959 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/config.py
@@ +751,5 @@
>              'update_platform': 'Android_arm-eabi-gcc3',
>              'enable_shared_checkouts': True,
> +            'use_mock': True,
> +            'mock_target': 'mozilla-centos6-i386',
> +            'mock_packages': ['autoconf213', 'mozilla-python27-mercurial', 'ccache', 'android-sdk15', 'android-ndk5', 'zip', 'java-1.6.0-openjdk-devel', 'zlib-devel', 'glibc-static', 'openssh-clients'],

Now that the android-sdk16 rpm is ready, can we make sure to include it here in the next iteration of the patch? Thanks.

Comment 6

[Chris AtLee [:catlee]]

Attachment: mock support for mozharness, and adjusting mobile_l10n.py to use it

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 651593 [details] [diff] [review]
mock support for mozharness, and adjusting mobile_l10n.py to use it

>diff --git a/configs/single_locale/mozilla-central_android.py b/configs/single_locale/mozilla-central_android.py

You'll need to land this with somewhat careful timing with the reconfig, but since we don't have good mobile l10n reporting as long as you get it green before the nightly we're probably good =\

(In reply to Chris Cooper [:coop] from comment #5)
> Now that the android-sdk16 rpm is ready, can we make sure to include it here
> in the next iteration of the patch? Thanks.

Are you putting this off til later, or did you miss this comment?

>+    def init_mock(self, mock_target):
>+        "Initialize mock environment defined by `mock_target`"
>+        cmd = ['mock_mozilla', '-r', mock_target, '--init']

Right now, we have to have mock_mozilla in PATH; to change which mock_mozilla we use, we have to change PATH (and it has to be named 'mock_mozilla').
If you want to allow for alternate mock_mozilla's, or a mock_mozilla that isn't in PATH, you can

    mock_mozilla = self.query_exe('mock_mozilla', return_type='list')
    cmd = mock_mozilla + ['-r', mock_target, '--init']

Feel free to use that if it's helpful; if it's not likely we'll need an alternate mock_mozilla, feel free to ignore.

>-class MobileSingleLocale(LocalesMixin, ReleaseMixin, MobileSigningMixin,
>-                         TransferMixin, BuildbotMixin, MercurialScript):
>+class MobileSingleLocale(MockMixin, LocalesMixin, ReleaseMixin,
>+                         MobileSigningMixin, TransferMixin,
>+                         BuildbotMixin, MercurialScript):

(Not specifically about this patch, just noticing):
This is one of the downsides of all the mixins.
We can consider consolidating some mixins later if it makes sense.

Thanks for this patch!

Comment 8

[Chris AtLee [:catlee]]

Attachment: use builder's environment for sendchange; copy more files required for android signing

the file copies can go away once we use the signing server

Comment 9

[Chris AtLee [:catlee]]

Attachment: buildbot-configs for fennec builds on mock

Comment 10

[Rail Aliiev [:rail]]

In production.