rm PND_INITIALIZED

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
PND_INITIALIZED is now almost entirely unused.  The one use (commented in the patch) really just wants to know whether we are initializing a const vs. assigning to it (bad).  Removing this removes several confusing blobs from the Parser.
(Assignee)

Comment 1

5 years ago
Created attachment 643920 [details] [diff] [review]
preparation: tidy BindVarOrConst

This is a trivial patch to merge branches in BindVarOrConst.
Attachment #643920 - Flags: review?(jimb)
(Assignee)

Comment 2

5 years ago
Created attachment 643921 [details] [diff] [review]
rm PND_INITIALIZED
Attachment #643921 - Flags: review?(jimb)
(Assignee)

Comment 3

5 years ago
Comment on attachment 643920 [details] [diff] [review]
preparation: tidy BindVarOrConst

Actually, ejpbruel has been getting into all this recently and volunteered himself for review.
Attachment #643920 - Flags: review?(jimb) → review?(ejpbruel)
(Assignee)

Updated

5 years ago
Attachment #643921 - Flags: review?(jimb) → review?(ejpbruel)
Comment on attachment 643920 [details] [diff] [review]
preparation: tidy BindVarOrConst

Review of attachment 643920 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. If the call to addHoist is never reached, are we getting rid of it as well?
Attachment #643920 - Flags: review+
Comment on attachment 643921 [details] [diff] [review]
rm PND_INITIALIZED

Review of attachment 643921 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. You might also want to remove the reference to the term 'fresh' on line 2264, since it no longer has any meaning after this patch.
Attachment #643921 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #643920 - Flags: review?(ejpbruel)
(Assignee)

Updated

5 years ago
Attachment #643921 - Flags: review?(ejpbruel)
Whiteboard: [js:t]
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b65ced8fa66b
https://hg.mozilla.org/integration/mozilla-inbound/rev/81cf39a89c70
Target Milestone: --- → mozilla17

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b65ced8fa66b
https://hg.mozilla.org/mozilla-central/rev/81cf39a89c70
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.