775647 - rm PND_INITIALIZED

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

PND_INITIALIZED is now almost entirely unused.  The one use (commented in the patch) really just wants to know whether we are initializing a const vs. assigning to it (bad).  Removing this removes several confusing blobs from the Parser.

Comment 1

[Luke Wagner [:luke]]

Attachment: preparation: tidy BindVarOrConst

This is a trivial patch to merge branches in BindVarOrConst.

Comment 2

[Luke Wagner [:luke]]

Attachment: rm PND_INITIALIZED

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 643920 [details] [diff] [review]
preparation: tidy BindVarOrConst

Actually, ejpbruel has been getting into all this recently and volunteered himself for review.

Comment 4

[Eddy Bruel [:ejpbruel]]

Comment on attachment 643920 [details] [diff] [review]
preparation: tidy BindVarOrConst

Review of attachment 643920 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. If the call to addHoist is never reached, are we getting rid of it as well?

Comment 5

[Eddy Bruel [:ejpbruel]]

Comment on attachment 643921 [details] [diff] [review]
rm PND_INITIALIZED

Review of attachment 643921 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. You might also want to remove the reference to the term 'fresh' on line 2264, since it no longer has any meaning after this patch.

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b65ced8fa66b
https://hg.mozilla.org/integration/mozilla-inbound/rev/81cf39a89c70

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b65ced8fa66b
https://hg.mozilla.org/mozilla-central/rev/81cf39a89c70