Last Comment Bug 775657 - [AccessFu] Add initial B2G support and dummy speech presenter
: [AccessFu] Add initial B2G support and dummy speech presenter
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: ARM Android
: -- normal (vote)
: mozilla17
Assigned To: Eitan Isaacson [:eeejay]
:
: alexander :surkov
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-19 10:54 PDT by Eitan Isaacson [:eeejay]
Modified: 2012-07-20 21:05 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Added initial B2G support and speech presenter. (5.32 KB, patch)
2012-07-19 10:55 PDT, Eitan Isaacson [:eeejay]
dbolter: review+
Details | Diff | Splinter Review

Description Eitan Isaacson [:eeejay] 2012-07-19 10:54:45 PDT

    
Comment 1 Eitan Isaacson [:eeejay] 2012-07-19 10:55:29 PDT
Created attachment 643931 [details] [diff] [review]
Added initial B2G support and speech presenter.
Comment 2 David Bolter [:davidb] 2012-07-19 11:27:39 PDT
Comment on attachment 643931 [details] [diff] [review]
Added initial B2G support and speech presenter.

Review of attachment 643931 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/AccessFu.jsm
@@ +64,5 @@
>  
>      // Implicitly add the Android presenter on Android.
>      if (Utils.OS == 'Android')
>        this.addPresenter(new AndroidPresenter());
> +    else if (Utils.MozBuildApp == 'b2g')

goosebumps.

::: accessible/src/jsat/Utils.jsm
@@ +19,5 @@
> +  _buildAppMap: {
> +    '{3c2e2abc-06d4-11e1-ac3b-374f68613e61}': 'b2g',
> +    '{ec8030f7-c20a-464f-9b0e-13a3a9e97384}': 'browser',
> +    '{aa3c5121-dab2-40e2-81ca-7ea25febc110}': 'mobile/android',
> +    '{a23983c0-fd0e-11dc-95ff-0800200c9a66}': 'mobile/xul'

Will these unique id's ever change?
Comment 3 Marco Zehe (:MarcoZ) 2012-07-20 01:56:59 PDT
Comment on attachment 643931 [details] [diff] [review]
Added initial B2G support and speech presenter.

>     if (Utils.OS == 'Android')
>       this.addPresenter(new AndroidPresenter());

Why aren't you using Utils.MozBuildApp here, too? Would be consistent, wouldn't it?

Other than that, I can only echo David: Goosebumps.
Comment 4 Eitan Isaacson [:eeejay] 2012-07-20 09:50:56 PDT
Added Marco's feedback.

http://hg.mozilla.org/integration/mozilla-inbound/rev/c8e7f3108013
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-20 21:05:31 PDT
https://hg.mozilla.org/mozilla-central/rev/c8e7f3108013

Note You need to log in before you can comment on or make changes to this bug.