Closed
Bug 775657
Opened 12 years ago
Closed 12 years ago
[AccessFu] Add initial B2G support and dummy speech presenter
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file)
5.32 KB,
patch
|
davidb
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #643931 -
Flags: review?(dbolter)
Comment 2•12 years ago
|
||
Comment on attachment 643931 [details] [diff] [review]
Added initial B2G support and speech presenter.
Review of attachment 643931 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/src/jsat/AccessFu.jsm
@@ +64,5 @@
>
> // Implicitly add the Android presenter on Android.
> if (Utils.OS == 'Android')
> this.addPresenter(new AndroidPresenter());
> + else if (Utils.MozBuildApp == 'b2g')
goosebumps.
::: accessible/src/jsat/Utils.jsm
@@ +19,5 @@
> + _buildAppMap: {
> + '{3c2e2abc-06d4-11e1-ac3b-374f68613e61}': 'b2g',
> + '{ec8030f7-c20a-464f-9b0e-13a3a9e97384}': 'browser',
> + '{aa3c5121-dab2-40e2-81ca-7ea25febc110}': 'mobile/android',
> + '{a23983c0-fd0e-11dc-95ff-0800200c9a66}': 'mobile/xul'
Will these unique id's ever change?
Attachment #643931 -
Flags: review?(dbolter) → review+
Comment 3•12 years ago
|
||
Comment on attachment 643931 [details] [diff] [review]
Added initial B2G support and speech presenter.
> if (Utils.OS == 'Android')
> this.addPresenter(new AndroidPresenter());
Why aren't you using Utils.MozBuildApp here, too? Would be consistent, wouldn't it?
Other than that, I can only echo David: Goosebumps.
Assignee | ||
Comment 4•12 years ago
|
||
Added Marco's feedback.
http://hg.mozilla.org/integration/mozilla-inbound/rev/c8e7f3108013
Assignee: nobody → eitan
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•