Closed
Bug 775680
Opened 12 years ago
Closed 12 years ago
Math.pow should use powi if the second argument is an integer-valued double
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jandem, Assigned: jandem)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
848 bytes,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
If a script calls Math.pow a lot, and the second argument is either int32 or double, the JITs always pass it as double. This means Math.pow should also use powi if the second argument is an integer-valued double. This may be a very small v8-raytrace/kraken-darkroom win, but I had to write the patch anyway to measure that so let's just fix it.
Attachment #643947 -
Flags: review?(dvander)
|
||
Updated•12 years ago
|
Attachment #643947 -
Flags: review?(dvander) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5c4c6e98b5c
Target Milestone: --- → mozilla17
|
||
Updated•12 years ago
|
Whiteboard: [js:t]
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b5c4c6e98b5c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•