Closed
Bug 775692
Opened 13 years ago
Closed 13 years ago
Rename rule.inheritedSource
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: paul, Assigned: harth)
Details
Attachments
(1 file)
|
1.69 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
As per comment: bug 712469 comment 73, we should rename rule.inheritedSource because its content has changed.
(In reply to Francesco Lodolo [:flod] from bug 712469 comment #73)
> -# e.g "Inherited from body#bodyID (styles.css:20)"
> -rule.inheritedSource=Inherited from %S (%S)
> +# e.g "Inherited from body#bodyID"
> +rule.inheritedSource=Inherited from %S
>
> I know I should probably open a new bug for this, but:
>
> a) don't change a string like this (removing a variable) without changing
> its name as well
> b) you should update its l10n comment (last line)
>
> # LOCALIZATION NOTE (rule.inheritedSource): Shown for CSS rules
> # that were inherited from a parent node. Will be passed a node
> # identifier and a source location.
|
Assignee | |
Comment 1•13 years ago
|
||
rename to "rule.inheritedFrom"
Assignee: nobody → fayearthur
Attachment #644019 -
Flags: review?(paul)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 644019 [details] [diff] [review]
rename string
r+
You didn't have to change the name. You could have changed it to rule.inheritedSource2.
Up to you.
Attachment #644019 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 17
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•