Rename rule.inheritedSource

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: paul, Assigned: harth)

Tracking

Trunk
Firefox 17
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
As per comment: bug 712469 comment 73, we should rename rule.inheritedSource because its content has changed.

(In reply to Francesco Lodolo [:flod] from bug 712469 comment #73)
> -# e.g "Inherited from body#bodyID (styles.css:20)"
> -rule.inheritedSource=Inherited from %S (%S)
> +# e.g "Inherited from body#bodyID"
> +rule.inheritedSource=Inherited from %S
> 
> I know I should probably open a new bug for this, but:
> 
> a) don't change a string like this (removing a variable) without changing
> its name as well
> b) you should update its l10n comment (last line)
> 
> # LOCALIZATION NOTE (rule.inheritedSource): Shown for CSS rules
> # that were inherited from a parent node.  Will be passed a node
> # identifier and a source location.
(Assignee)

Comment 1

5 years ago
Created attachment 644019 [details] [diff] [review]
rename string

rename to "rule.inheritedFrom"
Assignee: nobody → fayearthur
Attachment #644019 - Flags: review?(paul)
(Reporter)

Comment 2

5 years ago
Comment on attachment 644019 [details] [diff] [review]
rename string

r+

You didn't have to change the name. You could have changed it to rule.inheritedSource2.

Up to you.
Attachment #644019 - Flags: review?(paul) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/1b756e58e59a
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1b756e58e59a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.