775708 - A better mechanism of determining if you have root on device

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[[e-mail] [:onecyrenus]]

Attachment: A patch that checks the guid / uid of the current user to determine if they are root on the device

Current method is to listFiles in /data/data to determine if we have root on the device. 

I think we can do this using adb shell "id" command to get the guid / uid of the current user ?

Comment 1

[Jonathan Griffin (:jgriffin)]

The problem with the existing method is that /data/data is empty on B2G, so devicemanager never recognizes that we are running as root.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 643981 [details] [diff] [review]
A patch that checks the guid / uid of the current user to determine if they are root on the device

Review of attachment 643981 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/mobile/devicemanagerADB.py
@@ +808,5 @@
> +    response = p.stdout.readline()
> +    response = response.rstrip()
> +    response = response.split(' ')
> +    if (response[0].find('uid=0') < 0 or response[1].find('gid=0') < 0):
> +      print "NOT running as root ", response[0].find('uid=0')

do we want to raise a DMError here?

Comment 3

[Jonathan Griffin (:jgriffin)]

posted to try, just in case

Comment 4

[Jonathan Griffin (:jgriffin)]

try ate my last submission, tried again:  https://tbpl.mozilla.org/?tree=Try&rev=190945a1d0e7

Comment 5

[Mozilla RelEng Bot]

Try run for 190945a1d0e7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=190945a1d0e7
Results (out of 29 total builds):
    exception: 8
    success: 16
    warnings: 4
    failure: 1
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-190945a1d0e7

Comment 6

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/mozilla-central/rev/f91c1b55b396

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2bfd0b750bb1