775717 - GB Galaxy Note displays blue (and orange) border around highlighted top-site thumbnail

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: thumbnail_has_blue_border.png

STR:
1. On GB Galaxy Note, load about:home
2. Press and hold one of the top-site thumbnails.

ER:
Highlighted thumbnail has orange border on Galaxy Nexus.
AR:
Highlighted thumbnail has orange *and* blue borders on Galaxy Note.

* Please see the attached screenshot.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch moves the background to listSelector.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643998 [details] [diff] [review]
Patch

As for approval as needed

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Oh, its' only on fx17. If this was regressed by some patch that is being uplifted to beta, make sure this patch goes along.

Comment 4

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c8fb67caa30f

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 643998 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): about:home cleanup.
User impact if declined: Thumbnails will show both blue and orange highlights.
Testing completed (on m-c, etc.): Landed in inbound on 07/20
Risk to taking this patch (and alternatives if risky): None. This just uses the proper selector.
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8fb67caa30f

Comment 7

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/8a140e187c7f

Comment 8

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a37741b342b5

Comment 9

[Aaron Train [:aaronmt]]

Need a Gingerbread Note for verification

Comment 10

[Chris Peterson [:cpeterson]]

I verified Nightly 17, Aurora 16, and Beta 15 are fixed on my GB Galaxy Note.