775734 - remove dead hoisting code in BindVarOrConst

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: rm

This removes a bunch of gnarly hoisting code in BindVarOrConst that is never executed.  Passes jit and reftests, trying servering now...

Comment 1

[Luke Wagner [:luke]]

Attachment: combined patch for fuzzing (applies to cset f08c782d0112)

Removing old frontend cruft inevitably awakens hidden demons; I humbly request some fuzzing.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

feedback+ from fuzzing for an hour or two - no biggies found from me... yet. ;-)

Comment 3

[Christian Holler (:decoder)]

Comment on attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

Same here, nothing found so far. I'll leave it running over night though :)

Comment 4

[Luke Wagner [:luke]]

Awesome, thanks guys.

Comment 5

[Eddy Bruel [:ejpbruel]]

Comment on attachment 644014 [details] [diff] [review]
rm

Review of attachment 644014 [details] [diff] [review]:
-----------------------------------------------------------------

Afaict, you are right, and this is indeed all that code does. Thank you for putting in a comment as well :-)

Comment 6

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c72277eced5

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3c72277eced5