remove dead hoisting code in BindVarOrConst

RESOLVED FIXED in mozilla17

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 644014 [details] [diff] [review]
rm

This removes a bunch of gnarly hoisting code in BindVarOrConst that is never executed.  Passes jit and reftests, trying servering now...
Attachment #644014 - Flags: review?(ejpbruel)
(Assignee)

Comment 1

5 years ago
Created attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

Removing old frontend cruft inevitably awakens hidden demons; I humbly request some fuzzing.
Attachment #644027 - Flags: feedback?(gary)
Attachment #644027 - Flags: feedback?(choller)
Comment on attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

feedback+ from fuzzing for an hour or two - no biggies found from me... yet. ;-)
Attachment #644027 - Flags: feedback?(gary) → feedback+
Comment on attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

Same here, nothing found so far. I'll leave it running over night though :)
Attachment #644027 - Flags: feedback?(choller) → feedback+
(Assignee)

Comment 4

5 years ago
Awesome, thanks guys.
Whiteboard: [js:t]
Comment on attachment 644014 [details] [diff] [review]
rm

Review of attachment 644014 [details] [diff] [review]:
-----------------------------------------------------------------

Afaict, you are right, and this is indeed all that code does. Thank you for putting in a comment as well :-)
Attachment #644014 - Flags: review+
Attachment #644014 - Flags: review?(ejpbruel)
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c72277eced5
Target Milestone: --- → mozilla17

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3c72277eced5
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.