Last Comment Bug 775734 - remove dead hoisting code in BindVarOrConst
: remove dead hoisting code in BindVarOrConst
Status: RESOLVED FIXED
[js:t]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks: 775323
  Show dependency treegraph
 
Reported: 2012-07-19 14:23 PDT by Luke Wagner [:luke]
Modified: 2012-07-26 05:09 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
rm (6.55 KB, patch)
2012-07-19 14:23 PDT, Luke Wagner [:luke]
ejpbruel: review+
Details | Diff | Splinter Review
combined patch for fuzzing (applies to cset f08c782d0112) (27.77 KB, patch)
2012-07-19 14:58 PDT, Luke Wagner [:luke]
gary: feedback+
choller: feedback+
Details | Diff | Splinter Review

Description Luke Wagner [:luke] 2012-07-19 14:23:19 PDT
Created attachment 644014 [details] [diff] [review]
rm

This removes a bunch of gnarly hoisting code in BindVarOrConst that is never executed.  Passes jit and reftests, trying servering now...
Comment 1 Luke Wagner [:luke] 2012-07-19 14:58:48 PDT
Created attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

Removing old frontend cruft inevitably awakens hidden demons; I humbly request some fuzzing.
Comment 2 Gary Kwong [:gkw] [:nth10sd] 2012-07-19 17:36:23 PDT
Comment on attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

feedback+ from fuzzing for an hour or two - no biggies found from me... yet. ;-)
Comment 3 Christian Holler (:decoder) 2012-07-19 17:38:21 PDT
Comment on attachment 644027 [details] [diff] [review]
combined patch for fuzzing (applies to cset f08c782d0112)

Same here, nothing found so far. I'll leave it running over night though :)
Comment 4 Luke Wagner [:luke] 2012-07-19 17:39:44 PDT
Awesome, thanks guys.
Comment 5 Eddy Bruel [:ejpbruel] 2012-07-25 13:24:48 PDT
Comment on attachment 644014 [details] [diff] [review]
rm

Review of attachment 644014 [details] [diff] [review]:
-----------------------------------------------------------------

Afaict, you are right, and this is indeed all that code does. Thank you for putting in a comment as well :-)
Comment 7 Ed Morley [:emorley] 2012-07-26 05:09:02 PDT
https://hg.mozilla.org/mozilla-central/rev/3c72277eced5

Note You need to log in before you can comment on or make changes to this bug.