Closed
Bug 775801
Opened 12 years ago
Closed 12 years ago
LambdaIsGetElem should look for JSOP_GETALIASEDVAR
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: luke, Assigned: luke)
Details
(Whiteboard: [js:p1])
Attachments
(1 file, 1 obsolete file)
1.86 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
After bug 753158, LambdaIsGetElem should sniff JSOP_GETALIASEDVAR instead of JSOP_NAME. This fixes a 10ms regression on sunspider unpack-code after bug 753158.
Attachment #644102 -
Flags: review?(dvander)
Assignee | ||
Comment 1•12 years ago
|
||
oops
Attachment #644102 -
Attachment is obsolete: true
Attachment #644102 -
Flags: review?(dvander)
Attachment #644109 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #644109 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/970b733bd01d
Target Milestone: --- → mozilla17
Updated•12 years ago
|
Whiteboard: [js:t]
Updated•12 years ago
|
Whiteboard: [js:t] → [js:p1]
Assignee | ||
Comment 3•12 years ago
|
||
and backed out b/c of some bustage on talos... https://hg.mozilla.org/integration/mozilla-inbound/rev/10d1f5a84f4e
Target Milestone: mozilla17 → ---
Assignee | ||
Comment 4•12 years ago
|
||
Hah, there was a pre-existing (but less likely to be exercised, due to the use of dynamic name lookup) bug where we did upvar lookup in the current scope instead of the lambda's environment. D'oh.
Assignee | ||
Comment 5•12 years ago
|
||
Pushed with shell testcase: https://hg.mozilla.org/integration/mozilla-inbound/rev/f4e588e1b681
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → mozilla17
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f4e588e1b681
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•