Last Comment Bug 775801 - LambdaIsGetElem should look for JSOP_GETALIASEDVAR
: LambdaIsGetElem should look for JSOP_GETALIASEDVAR
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Luke Wagner [:luke]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-07-19 17:53 PDT by Luke Wagner [:luke]
Modified: 2012-07-20 21:02 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (1.70 KB, patch)
2012-07-19 17:53 PDT, Luke Wagner [:luke]
no flags Details | Diff | Splinter Review
qref'd (1.86 KB, patch)
2012-07-19 18:12 PDT, Luke Wagner [:luke]
dvander: review+
Details | Diff | Splinter Review

Description Luke Wagner [:luke] 2012-07-19 17:53:40 PDT
Created attachment 644102 [details] [diff] [review]

After bug 753158, LambdaIsGetElem should sniff JSOP_GETALIASEDVAR instead of JSOP_NAME.  This fixes a 10ms regression on sunspider unpack-code after bug 753158.
Comment 1 Luke Wagner [:luke] 2012-07-19 18:12:39 PDT
Created attachment 644109 [details] [diff] [review]

Comment 3 Luke Wagner [:luke] 2012-07-20 15:37:25 PDT
and backed out b/c of some bustage on talos...
Comment 4 Luke Wagner [:luke] 2012-07-20 16:20:11 PDT
Hah, there was a pre-existing (but less likely to be exercised, due to the use of dynamic name lookup) bug where we did upvar lookup in the current scope instead of the lambda's environment.  D'oh.
Comment 5 Luke Wagner [:luke] 2012-07-20 16:21:20 PDT
Pushed with shell testcase:
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-20 21:02:38 PDT

Note You need to log in before you can comment on or make changes to this bug.