Closed Bug 775801 Opened 12 years ago Closed 12 years ago

LambdaIsGetElem should look for JSOP_GETALIASEDVAR

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: luke, Assigned: luke)

Details

(Whiteboard: [js:p1])

Attachments

(1 file, 1 obsolete file)

Attached patch fix (obsolete) — Splinter Review
After bug 753158, LambdaIsGetElem should sniff JSOP_GETALIASEDVAR instead of JSOP_NAME.  This fixes a 10ms regression on sunspider unpack-code after bug 753158.
Attachment #644102 - Flags: review?(dvander)
Attached patch qref'dSplinter Review
oops
Attachment #644102 - Attachment is obsolete: true
Attachment #644102 - Flags: review?(dvander)
Attachment #644109 - Flags: review?(dvander)
Attachment #644109 - Flags: review?(dvander) → review+
Whiteboard: [js:t]
Whiteboard: [js:t] → [js:p1]
and backed out b/c of some bustage on talos...
https://hg.mozilla.org/integration/mozilla-inbound/rev/10d1f5a84f4e
Target Milestone: mozilla17 → ---
Hah, there was a pre-existing (but less likely to be exercised, due to the use of dynamic name lookup) bug where we did upvar lookup in the current scope instead of the lambda's environment.  D'oh.
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/f4e588e1b681
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.