Closed
Bug 775817
Opened 14 years ago
Closed 14 years ago
Update tests to use the new permission manager api
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
65.74 KB,
patch
|
sicking
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
This patch should updates [nearly] all tests using the permission manager. Tests that this patch are not updating are:
- tests using SpecialPowers (there are a couple of them), see bug 775815;
- tests using Services.perms;
- tests I missed.
I will try to write a new patch for the second category.
| Assignee | ||
Comment 1•14 years ago
|
||
Attachment #644138 -
Flags: review?(jonas)
Comment on attachment 644138 [details] [diff] [review]
Patch
Review of attachment 644138 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with that fixed.
::: netwerk/test/unit/test_fallback_request-error_passing.js
@@ +69,5 @@
> var pm = Cc["@mozilla.org/permissionmanager;1"]
> .getService(Ci.nsIPermissionManager);
> var uri = make_uri("http://localhost:4444");
> + var principal = CC["@mozilla.org/scriptsecuritymanager;1"]
> + .getService(Ci.nsIScriptSecurityManager)
All of these, change to just Services.perms
Attachment #644138 -
Flags: review?(jonas) → review+
| Assignee | ||
Comment 3•14 years ago
|
||
This is not updating all tests but quite most of them. We will open new bugs for the others.
Flags: in-testsuite+
Target Milestone: --- → mozilla17
| Assignee | ||
Updated•14 years ago
|
Attachment #644138 -
Flags: checkin+
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•