The default bug view has changed. See this FAQ.

Update tests to use the new permission manager api

RESOLVED FIXED in mozilla17

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This patch should updates [nearly] all tests using the permission manager. Tests that this patch are not updating are:
- tests using SpecialPowers (there are a couple of them), see bug 775815;
- tests using Services.perms;
- tests I missed.

I will try to write a new patch for the second category.
(Assignee)

Comment 1

5 years ago
Created attachment 644138 [details] [diff] [review]
Patch
Attachment #644138 - Flags: review?(jonas)
Comment on attachment 644138 [details] [diff] [review]
Patch

Review of attachment 644138 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed.

::: netwerk/test/unit/test_fallback_request-error_passing.js
@@ +69,5 @@
>    var pm = Cc["@mozilla.org/permissionmanager;1"]
>      .getService(Ci.nsIPermissionManager);
>    var uri = make_uri("http://localhost:4444");
> +  var principal = CC["@mozilla.org/scriptsecuritymanager;1"]
> +                    .getService(Ci.nsIScriptSecurityManager)

All of these, change to just Services.perms
Attachment #644138 - Flags: review?(jonas) → review+
(Assignee)

Comment 3

5 years ago
This is not updating all tests but quite most of them. We will open new bugs for the others.
Flags: in-testsuite+
Target Milestone: --- → mozilla17
(Assignee)

Updated

5 years ago
Attachment #644138 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/0ff084e6a9e3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.