775822 - B2G shell.js and CameraContent.js should use the new permission manager api

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

In my opinion, this code is completely buggy. I make the !testPermission() more explicit so it's clear what the code is doing.

Vivien, can you tell me what this code is expected to do.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 644146 [details] [diff] [review]
Patch

Review of attachment 644146 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/chrome/content/shell.js
@@ +244,5 @@
>            let manifest = documentElement.getAttribute('manifest');
>            if (!manifest)
>              return;
>  
> +          if (!Services.perms.testPermissionFromPrincipal(contentWindow.document.nodePrincipal, 'offline-app') != Ci.nsIPermissionManager.UNKNOWN_ACTION) {

I think there is an extra ! somewhere :)

Also can you |let principal = contentWindow.document.nodePrincipal;| and use that to kill this extra long line.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 644146 [details] [diff] [review]
Patch

Review of attachment 644146 [details] [diff] [review]:
-----------------------------------------------------------------

Don't forget to fix the ! before landing.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/084e70fe3e0c