Last Comment Bug 775829 - Updating browser id to use the new permission manager api
: Updating browser id to use the new permission manager api
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: Identity (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Mounir Lamouri (:mounir)
:
: Fernando Jiménez Moreno [:ferjm]
Mentors:
Depends on: 769583
Blocks: app-data-jars
  Show dependency treegraph
 
Reported: 2012-07-19 20:03 PDT by Mounir Lamouri (:mounir)
Modified: 2012-09-01 08:02 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+


Attachments
Patch (1.84 KB, patch)
2012-07-19 20:03 PDT, Mounir Lamouri (:mounir)
jonas: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2012-07-19 20:03:19 PDT
Created attachment 644152 [details] [diff] [review]
Patch

Jonas, feel free to redirect the review to a BrowserID peer (if such thing exist) if you don't feel comfortable reviewing that.
Comment 1 Ryan VanderMeulen [:RyanVM] 2012-07-21 06:21:14 PDT
https://hg.mozilla.org/mozilla-central/rev/d60807c526a5
Comment 2 Ben Adida [:benadida] 2012-07-22 10:13:46 PDT
Mounir, Jonas: can you explain what this change does?
Comment 3 Mounir Lamouri (:mounir) 2012-07-22 11:22:39 PDT
Instead of using the permission manager using an URI, this code is using the permission manager using a principal, which carries more information than an URI. The idea is to have at some point, when all consumers of the permission manager will be changed, to have the permission manager using the principal's appid.

Note You need to log in before you can comment on or make changes to this bug.