775844 - Need to include constructor signature types when we make up our lists of types to examine

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Otherwise, for example, using a union type in a constructor argument doesn't actually pick it up as a type to generate union stuff for.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure to examine constructor signatures when looking for union types.

Also includes some distinguishability fixes

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure to examine constructor signatures when looking for union types.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure to examine constructor signatures when looking for union types.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Why are the tests commented out?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Because union codegen dumps all the unions in a single header file and that file is included from all bindings that use unions.  So if I uncomment that, the header file ends up with TestInterface* and whatnot in it and real (non-test) bindings that use unions can't find the test headers and fail to build.

I can add a comment to that effect to the test webidl if desired.

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 644345 [details] [diff] [review]
Make sure to examine constructor signatures when looking for union types.

Review of attachment 644345 [details] [diff] [review]:
-----------------------------------------------------------------

Ok.

Comment 7

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3a7ac28c4ca9

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a7ac28c4ca9