BasicShadowLayerManager::mRepeatTransaction is uninitialized

RESOLVED FIXED in Firefox 16

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: karlt)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox16+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This changeset for Bug 771219...
 https://hg.mozilla.org/mozilla-central/rev/265258de61ec
added a boolean member-var BasicShadowLayerManager::mRepeatTransaction, which isn't necessarily ever set, though it is read, during "BasicShadowLayerManager::EndTransaction().

We should probably be initializing it, to false I imagine.

I ran across this due to the following valgrind warning, near startup:
==19324== Conditional jump or move depends on uninitialised value(s)
==19324==    at 0x99B01F3: mozilla::layers::BasicShadowLayerManager::EndTransaction(void (*)(mozilla::layers::ThebesLayer*, gfxContext*, nsIntRegion const&, nsIntRegi
on const&, void*), void*, mozilla::layers::LayerManager::EndTransactionFlags) (BasicLayerManager.cpp:1001)
==19324==    by 0x8291D2A: nsDisplayList::PaintForFrame(nsDisplayListBuilder*, nsRenderingContext*, nsIFrame*, unsigned int) const (nsDisplayList.cpp:651)
==19324==    by 0x82915D2: nsDisplayList::PaintRoot(nsDisplayListBuilder*, nsRenderingContext*, unsigned int) const (nsDisplayList.cpp:549)
==19324==    by 0x82C85B7: nsLayoutUtils::PaintFrame(nsRenderingContext*, nsIFrame*, nsRegion const&, unsigned int, unsigned int) (nsLayoutUtils.cpp:1786)
==19324==    by 0x82F4FB3: PresShell::Paint(nsIView*, nsIWidget*, nsRegion const&, nsIntRegion const&, bool) (nsPresShell.cpp:5278)
==19324==    by 0x8A692C6: nsViewManager::Refresh(nsView*, nsIWidget*, nsIntRegion const&, bool) (nsViewManager.cpp:339)
==19324==    by 0x8A6A77E: nsViewManager::DispatchEvent(nsGUIEvent*, nsIView*, nsEventStatus*) (nsViewManager.cpp:768)
==19324==    by 0x8A64DBC: HandleEvent(nsGUIEvent*) (nsView.cpp:127)
==19324==    by 0x956F934: nsWindow::DispatchEvent(nsGUIEvent*, nsEventStatus&) (nsWindow.cpp:474)
==19324==    by 0x95739A8: nsWindow::OnExposeEvent(_GdkEventExpose*) (nsWindow.cpp:2213)
==19324==    by 0x957B622: expose_event_cb(_GtkWidget*, _GdkEventExpose*) (nsWindow.cpp:5091)
==19324==    by 0xE1F3DD7: _gtk_marshal_BOOLEAN__BOXED (gtkmarshalers.c:86)
(Assignee)

Comment 1

5 years ago
Created attachment 647032 [details] [diff] [review]
Initialize
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Attachment #647032 - Flags: review?(bgirard)
(Assignee)

Comment 2

5 years ago
Not sure how much repeating the transaction unnecessarily could affect performance.
It should happen only once per layer manager.
But this should be a trivial fix for Aurora.
tracking-firefox16: --- → ?
Comment on attachment 647032 [details] [diff] [review]
Initialize

Wow sorry about that. I think the repeat transaction wont do anything expensive (draw/upload) since it will have completed before. That said I rather just patch it and not take the risk. Let's uplift this to aurora.
Attachment #647032 - Flags: review?(bgirard) → review+

Updated

5 years ago
Duplicate of this bug: 778071

Updated

5 years ago
tracking-firefox16: ? → +
(Assignee)

Comment 5

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=47e0b459eb76
https://hg.mozilla.org/integration/mozilla-inbound/rev/701fd0265295
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/701fd0265295
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Comment 7

5 years ago
Comment on attachment 647032 [details] [diff] [review]
Initialize

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 771219
User impact if declined: possible performance impact in rare situations, valgrind warnings.
Testing completed (on m-c, etc.): on m-c.
Risk to taking this patch (and alternatives if risky): none.
String or UUID changes made by this patch: none.
Attachment #647032 - Flags: approval-mozilla-aurora?
Comment on attachment 647032 [details] [diff] [review]
Initialize

low risk, approving.
Attachment #647032 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/c9c87187e30b
status-firefox16: --- → fixed
You need to log in before you can comment on or make changes to this bug.