Created attachment 644204 [details] [diff] [review] v1 We need this so we can propagate these fields in e10s from child necko channels to parent ones, and nsILoadContext is available to all content-serving channels (according to bz), while nsIDocShell is not.
I'd appreciate it if there were no mention of "docshell" in nsILoadContext. The idea of nsILoadContext was that it should be completely docshell-agnostic, and should work fine even when there are no docshells involved. Please just document what the members mean....
Created attachment 644217 [details] [diff] [review] v2: remove mention of docshell from member description
Created attachment 644218 [details] [diff] [review] v3: OMG hello qref
r=me, but if you find yourself doing (loadContext.isInBrowserElement || loadContext.appID != 0) you should add loadContext::isBelowContentBoundary, per bug 774957.
Attachment #644218 - Flags: review?(justin.lebar+bug) → review+
Attachment #644218 - Flags: superreview?(jonas) → superreview+
blocking-basecamp: --- → +
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.