Note: There are a few cases of duplicates in user autocompletion which are being worked on.

copy appId and isInBrowserElement from nsIDocShell to nsILoadContext

RESOLVED FIXED in mozilla17

Status

()

Core
General
RESOLVED FIXED
5 years ago
11 months ago

People

(Reporter: jduell, Assigned: jduell)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 644204 [details] [diff] [review]
v1

We need this so we can propagate these fields in e10s from child necko channels to parent ones, and nsILoadContext is available to all content-serving channels (according to bz), while nsIDocShell is not.
Attachment #644204 - Flags: superreview?(jonas)
Attachment #644204 - Flags: review?(justin.lebar+bug)

Comment 1

5 years ago
I'd appreciate it if there were no mention of "docshell" in nsILoadContext.  The idea of nsILoadContext was that it should be completely docshell-agnostic, and should work fine even when there are no docshells involved.  Please just document what the members mean....
(Assignee)

Updated

5 years ago
Blocks: 775861
(Assignee)

Comment 2

5 years ago
Created attachment 644217 [details] [diff] [review]
v2: remove mention of docshell from member description
Assignee: nobody → jduell.mcbugs
Attachment #644204 - Attachment is obsolete: true
Attachment #644204 - Flags: superreview?(jonas)
Attachment #644204 - Flags: review?(justin.lebar+bug)
Attachment #644217 - Flags: superreview?(jonas)
Attachment #644217 - Flags: review?(justin.lebar+bug)
(Assignee)

Comment 3

5 years ago
Created attachment 644218 [details] [diff] [review]
v3: OMG hello qref
Attachment #644217 - Attachment is obsolete: true
Attachment #644217 - Flags: superreview?(jonas)
Attachment #644217 - Flags: review?(justin.lebar+bug)
Attachment #644218 - Flags: superreview?(jonas)
Attachment #644218 - Flags: review?(justin.lebar+bug)
r=me, but if you find yourself doing

  (loadContext.isInBrowserElement || loadContext.appID != 0)

you should add loadContext::isBelowContentBoundary, per bug 774957.
Attachment #644218 - Flags: review?(justin.lebar+bug) → review+
Attachment #644218 - Flags: superreview?(jonas) → superreview+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2c5ae47895
blocking-basecamp: --- → +
https://hg.mozilla.org/mozilla-central/rev/bc2c5ae47895
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Updated

5 years ago
Blocks: 777620
Blocks: 1294638
You need to log in before you can comment on or make changes to this bug.