Last Comment Bug 775860 - copy appId and isInBrowserElement from nsIDocShell to nsILoadContext
: copy appId and isInBrowserElement from nsIDocShell to nsILoadContext
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jason Duell [:jduell] (needinfo me)
:
:
Mentors:
Depends on: 770831
Blocks: 777620 775861 1294638
  Show dependency treegraph
 
Reported: 2012-07-20 00:23 PDT by Jason Duell [:jduell] (needinfo me)
Modified: 2016-08-12 00:02 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+


Attachments
v1 (2.98 KB, patch)
2012-07-20 00:23 PDT, Jason Duell [:jduell] (needinfo me)
no flags Details | Diff | Splinter Review
v2: remove mention of docshell from member description (2.98 KB, patch)
2012-07-20 00:59 PDT, Jason Duell [:jduell] (needinfo me)
no flags Details | Diff | Splinter Review
v3: OMG hello qref (2.79 KB, patch)
2012-07-20 01:02 PDT, Jason Duell [:jduell] (needinfo me)
justin.lebar+bug: review+
jonas: superreview+
Details | Diff | Splinter Review

Description Jason Duell [:jduell] (needinfo me) 2012-07-20 00:23:43 PDT
Created attachment 644204 [details] [diff] [review]
v1

We need this so we can propagate these fields in e10s from child necko channels to parent ones, and nsILoadContext is available to all content-serving channels (according to bz), while nsIDocShell is not.
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2012-07-20 00:30:30 PDT
I'd appreciate it if there were no mention of "docshell" in nsILoadContext.  The idea of nsILoadContext was that it should be completely docshell-agnostic, and should work fine even when there are no docshells involved.  Please just document what the members mean....
Comment 2 Jason Duell [:jduell] (needinfo me) 2012-07-20 00:59:27 PDT
Created attachment 644217 [details] [diff] [review]
v2: remove mention of docshell from member description
Comment 3 Jason Duell [:jduell] (needinfo me) 2012-07-20 01:02:31 PDT
Created attachment 644218 [details] [diff] [review]
v3: OMG hello qref
Comment 4 Justin Lebar (not reading bugmail) 2012-07-20 07:32:21 PDT
r=me, but if you find yourself doing

  (loadContext.isInBrowserElement || loadContext.appID != 0)

you should add loadContext::isBelowContentBoundary, per bug 774957.
Comment 5 Jason Duell [:jduell] (needinfo me) 2012-07-20 11:39:41 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2c5ae47895
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-07-20 21:03:53 PDT
https://hg.mozilla.org/mozilla-central/rev/bc2c5ae47895

Note You need to log in before you can comment on or make changes to this bug.