Closed Bug 775860 Opened 11 years ago Closed 11 years ago

copy appId and isInBrowserElement from nsIDocShell to nsILoadContext

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17
Project Flags:
blocking-basecamp +

People

(Reporter: jduell.mcbugs, Assigned: jduell.mcbugs)

References

Details

Attachments

(1 file, 2 obsolete files)

v3: OMG hello qref
2.79 KB, patch
justin.lebar+bug
: review+
sicking
: superreview+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
We need this so we can propagate these fields in e10s from child necko channels to parent ones, and nsILoadContext is available to all content-serving channels (according to bz), while nsIDocShell is not.
Attachment #644204 - Flags: superreview?(jonas)
Attachment #644204 - Flags: review?(justin.lebar+bug)
I'd appreciate it if there were no mention of "docshell" in nsILoadContext.  The idea of nsILoadContext was that it should be completely docshell-agnostic, and should work fine even when there are no docshells involved.  Please just document what the members mean....
Blocks: 775861
Assignee: nobody → jduell.mcbugs

        Attachment #644204 -
        Attachment is obsolete: true

        Attachment #644204 -
        Flags: superreview?(jonas)

        Attachment #644204 -
        Flags: review?(justin.lebar+bug)

        Attachment #644217 -
        Flags: superreview?(jonas)

        Attachment #644217 -
        Flags: review?(justin.lebar+bug)

    
    

    
  


  

        Attachment #644217 -
        Attachment is obsolete: true

        Attachment #644217 -
        Flags: superreview?(jonas)

        Attachment #644217 -
        Flags: review?(justin.lebar+bug)

        Attachment #644218 -
        Flags: superreview?(jonas)

        Attachment #644218 -
        Flags: review?(justin.lebar+bug)

    
    

    
  
r=me, but if you find yourself doing

  (loadContext.isInBrowserElement || loadContext.appID != 0)

you should add loadContext::isBelowContentBoundary, per bug 774957.

        Attachment #644218 -
        Flags: review?(justin.lebar+bug) → review+

        Attachment #644218 -
        Flags: superreview?(jonas) → superreview+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/bc2c5ae47895
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17

    
  
Blocks: 777620

          You need to log in
          before you can comment on or make changes to this bug.