77588 - charset menu entry for cp866 wrong

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[bobj]

Currently we display in the Character Coding men
   Cyrillic/Russian (IBM-866)

This should display as
   Cyrillic/Russian (CP-866)

(1) Need to change "ibm866" => "cp866" in
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/locale/en-US/navi
gator.properties
(2) Need to change 
       cp-866.title = Cyrillic (CP-866)
to
       cp-866.title = Cyrillic/Russian (CP-866)
in 
http://lxr.mozilla.org/seamonkey/source/intl/uconv/src/charsetTitles.properties
(3) Should delete
       ibm866.title = Cyrillic/Russian (IBM-866)
in 
http://lxr.mozilla.org/seamonkey/source/intl/uconv/src/charsetTitles.properties

Comment 1

[nhottanscp]

Reassign to jbetak.

Comment 2

[[e-mail] (away - not reading bugmail)]

accepting, targeting for 0.9.1

Comment 3

[[e-mail] (away - not reading bugmail)]

Bob,

I've had another look at this and it seems, that there is only one converter - 
CP866:

http://lxr.mozilla.org/seamonkey/source/intl/uconv/ucvlatin/nsUnicodeToCP866.cpp
http://lxr.mozilla.org/seamonkey/source/intl/uconv/ucvlatin/nsCP866ToUnicode.cpp

Currently, this registers as "ibm866" with the converter factory:

http://lxr.mozilla.org/seamonkey/source/intl/uconv/ucvlatin/nsUCvLatinModule.cpp
#919
http://lxr.mozilla.org/seamonkey/source/intl/uconv/ucvlatin/nsUCvLatinModule.cpp
#577

and is aliased with cp866 and 866:

http://lxr.mozilla.org/seamonkey/source/intl/uconv/src/charsetalias.properties#3
05

Keeping both cp-866.title and ibm866.title would only make sense, if we had two 
separate converters, which is obviously not the case. The most expedient fix 
would be setting ibm866.title=Cyrillic/Russian (CP-866), removing cp-866.title 
and aliasing it to ibm866. 

A better, yet more laborious solution is to eradicate the ibm866 converter, 
change the nsUnicodeToCP866.cpp and nsCP866ToUnicode.cpp registration to cp-866 
and subsequently alias cp866, 866 and ibm-866 to cp-866. There is some 
potential for regression bugs, and I just wanted to point out these options to 
see, what would be the best course of action.

Comment 4

[bobj]

I agree we should have only one *866.title.

Why does it matter which name we use to register the converter as long as
the other names are aliased?  Is it just for consistency?  Functionally, either
way is equivalent, right?

Comment 5

[[e-mail] (away - not reading bugmail)]

yes, it would be just for naming consistency?  There is no functional impact.

Comment 6

[[e-mail] (away - not reading bugmail)]

Attachment: preliminary patch cvs diff -u -b -w .\intl\uconv\src\charset*.* >bug77588.txt

Comment 7

[[e-mail] (away - not reading bugmail)]

Naoki,

I think this one is also ready for review. Maybe we can speed up the sr process 
by having Frank do it since all changes are constrained to the i18n module.

I took the safest road - keeping the ibm866 converter, changing it's title and 
aliasing all cp866 incarnations to ibm866. 

Since the underlying files are named nsUnicodeToCP866.cpp and 
nsCP866ToUnicode.cpp we might want to change the converter registration from 
ibm866 to cp-866 and reverse the aliasing for naming consistency later. If you 
agree, I'll file a tracking bug for that task and future it.

Comment 8

[nhottanscp]

r=nhotta

Comment 9

[[e-mail] (away - not reading bugmail)]

ftang,

can you act as interim super-reviewer for i18n issues?

Comment 10

[Frank Tang]

blizzard- please supre review this changes. 

Comment 11

[Frank Tang]

r=ftang

Comment 12

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 13

[[e-mail] (away - not reading bugmail)]

Bob:

I'm going to close this bug. The change to CP-866 should be visible starting 
from the 20010510 build. There is a follow-up bug 79911 to address the 
remaining naming consistency issue.

Comment 14

[Yuying Long]

Verified the menu item has been changed to: Cyrillic/Russian (CP-866) on 05-11 
trunk build.