Closed Bug 775978 Opened 13 years ago Closed 13 years ago

Disable button fixes

Categories

(Marketplace Graveyard :: Reviewer Tools, defect)

Product:
Marketplace Graveyard
Component:
Reviewer Tools
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2012-07-26

People

(Reporter: robhudson, Assigned: robhudson)

References

Details

1. Show disable button if status not in [amo.STATUS_REJECTED, amo.STATUS_DISABLED] 2. Only show disable button for senior reviewers
(In reply to Rob Hudson [:robhudson] from comment #0) > 1. Show disable button if status not in [amo.STATUS_REJECTED, > amo.STATUS_DISABLED] Thinking about it, this limitation is probably unnecessary (we may want to disable a rejected app and showing disable for a disabled app is harmless). the second part is the important bit.
https://github.com/mozilla/zamboni/commit/a32c864 This adds a new group, "Senior App Reviewers", that nobody is in. Populate with users as needed. The "disable" action is limited to users with "Addon:Edit" permissions, which both "Senior App Reviewers" and "Senior Add-on Reviewers" have.
Assignee: nobody → robhudson.mozbugs
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2012-07-26
we now have a 'Disable App' button. checked that disabling works. verified at https://marketplace-dev.allizom.org/en-US/app/marble-run-1343322852/ Disable app only shows up for admins and Senior reviewers.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.