Last Comment Bug 776016 - "@foo@.in: WARNING: no preprocessor directives found" when running Preprocessor unit test
: "@foo@.in: WARNING: no preprocessor directives found" when running Preprocess...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Mike Hommey [:glandium]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-20 09:58 PDT by Mike Hommey [:glandium]
Modified: 2012-07-26 05:12 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Avoid warning when running unit-Preprocessor.py (948 bytes, patch)
2012-07-20 09:59 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review
Avoid Preprocessor.py warning when no commands are processed, but filters are (1.52 KB, patch)
2012-07-24 10:44 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2012-07-20 09:58:36 PDT

    
Comment 1 Mike Hommey [:glandium] 2012-07-20 09:59:45 PDT
Created attachment 644376 [details] [diff] [review]
Avoid warning when running unit-Preprocessor.py
Comment 2 Ted Mielczarek [:ted.mielczarek] 2012-07-23 12:39:23 PDT
Comment on attachment 644376 [details] [diff] [review]
Avoid warning when running unit-Preprocessor.py

Review of attachment 644376 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but why do we warn in this case? We are doing a substitution, just not using preprocessor directives. That seems like a valid use of Preprocessor.py.
Comment 3 Mike Hommey [:glandium] 2012-07-24 10:44:51 PDT
Created attachment 645375 [details] [diff] [review]
Avoid Preprocessor.py warning when no commands are processed, but filters are
Comment 5 Ed Morley [:emorley] 2012-07-25 01:37:39 PDT
Push backed out for Windows mochitest crashes:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=eecd3aa199e6

https://hg.mozilla.org/integration/mozilla-inbound/rev/1abfd50c8be6
Comment 6 Mike Hommey [:glandium] 2012-07-25 04:08:50 PDT
Relanded, as it was innocent
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0a8b539d562
Comment 7 Ed Morley [:emorley] 2012-07-26 05:12:58 PDT
https://hg.mozilla.org/mozilla-central/rev/e0a8b539d562

Note You need to log in before you can comment on or make changes to this bug.