776016 - "@foo@.in: WARNING: no preprocessor directives found" when running Preprocessor unit test

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid warning when running unit-Preprocessor.py

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 644376 [details] [diff] [review]
Avoid warning when running unit-Preprocessor.py

Review of attachment 644376 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but why do we warn in this case? We are doing a substitution, just not using preprocessor directives. That seems like a valid use of Preprocessor.py.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Avoid Preprocessor.py warning when no commands are processed, but filters are

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4e68cf2bd40

Comment 5

[Ed Morley [:emorley]]

Push backed out for Windows mochitest crashes:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=eecd3aa199e6

https://hg.mozilla.org/integration/mozilla-inbound/rev/1abfd50c8be6

Comment 6

[Mike Hommey [:glandium]]

Relanded, as it was innocent
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0a8b539d562

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e0a8b539d562