776067 - XHDPI GB icons for menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Galaxy Note is a XHDPI device. We currently don't have XHDPI icons for GB. Galaxy Note's menu shows the custom menu based icons -- which doesnt match.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This replaces the required icons.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 644419 [details] [diff] [review]
Patch

Passing review. I am PTO soon.

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 644419 [details] [diff] [review]
Patch

This changes the MDPI and HDPI icons, as well as the XHDPI ones.  This is intentional, right?  It looks like they are all changing to more gingerbread-style menu icons, so the changes look correct to me.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Ian asked me to replace all the icons (probably he changed something in them), hence replace the mdpi and hdpi too.

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ce8a9f561501

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 644419 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): We never support XHDPI phones on GB. Now with Galaxy Note, we need GB like menu on XHDPI device.
User impact if declined: Note's menu icons wont look good.
Testing completed (on m-c, etc.): Landed on inbound on 07/20.
Risk to taking this patch (and alternatives if risky): None. This just replaces the images.
String or UUID changes made by this patch: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ce8a9f561501

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 644419 [details] [diff] [review]
Patch

[Triage Comment]
Approving for branches, given this is a low risk image change.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/55de04170f3c

Comment 10

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-beta/rev/791622779dd7

Comment 11

[Sriram Ramasubramanian [:sriram]]

ic_menu_reading_list_*.png shouldn't have been added to beta in https://hg.mozilla.org/releases/mozilla-aurora/rev/479756495eed
This is not supported in beta yet. Hence they are removed in this patch (which ideally should have replaced the icons).

Comment 12

[Aaron Train [:aaronmt]]

Need someone on a Note (Gingerbread) to verify this, my Note is on 4.0.4